From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com,
Wentong Wu <wentong.wu@intel.com>
Subject: Re: [PATCH v4 3/4] media: Documentation: Update link frequency driver documentation
Date: Tue, 30 Apr 2024 07:31:01 +0000 [thread overview]
Message-ID: <ZjCeNcF1nkt6WKUS@kekkonen.localdomain> (raw)
In-Reply-To: <ojsquq4vgzyxubla4uv6ntgm4p7zoqpn5vqqza5dmevxlosy6l@2icfz6thrffp>
Hi Jacopo,
On Tue, Apr 30, 2024 at 09:23:52AM +0200, Jacopo Mondi wrote:
> Hi Sakari
>
> On Mon, Apr 29, 2024 at 10:08:51PM +0300, Sakari Ailus wrote:
> > Add the get_mbus_config() as the means for conveying the link frequency
> > towards the receiver drivers.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> > ---
> > Documentation/driver-api/media/tx-rx.rst | 4 ++++
> > 1 file changed, 4 insertions(+)
> >
> > diff --git a/Documentation/driver-api/media/tx-rx.rst b/Documentation/driver-api/media/tx-rx.rst
> > index 29d66a47b56e..2f22a1534da9 100644
> > --- a/Documentation/driver-api/media/tx-rx.rst
> > +++ b/Documentation/driver-api/media/tx-rx.rst
> > @@ -49,6 +49,10 @@ Link frequency
> > The :ref:`V4L2_CID_LINK_FREQ <v4l2-cid-link-freq>` control is used to tell the
> > receiver the frequency of the bus (i.e. it is not the same as the symbol rate).
> >
> > +For devices where the link frequency is read-only, the link_freq field of struct
>
> A control can be 'read-only' as well.
>
> What about something along the lines of:
>
> For devices where the link frequency doesn't need to be exposed to userspace,
> the link_freq field of struct
I think we could use something like that. The LINK_FREQ control indeed
allows choosing this from the user space but other than that it has little
use AFAIU.
>
> > +v4l2_mbus_config is recommended over controls for conveying the link frequency
> > +to the downstream driver in the pipeline.
> > +
> > ``.s_stream()`` callback
> > ^^^^^^^^^^^^^^^^^^^^^^^^
> >
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2024-04-30 7:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 19:08 [PATCH v4 0/4] Use V4L2 mbus config for conveying MEI CSI link frequency Sakari Ailus
2024-04-29 19:08 ` [PATCH v4 1/4] media: v4l: Support passing sub-device argument to v4l2_get_link_freq() Sakari Ailus
2024-04-30 7:01 ` Jacopo Mondi
2024-04-30 7:27 ` Sakari Ailus
2024-04-29 19:08 ` [PATCH v4 2/4] media: v4l: Support obtaining link frequency via get_mbus_config Sakari Ailus
2024-04-30 7:19 ` Jacopo Mondi
2024-04-30 7:29 ` Sakari Ailus
2024-04-29 19:08 ` [PATCH v4 3/4] media: Documentation: Update link frequency driver documentation Sakari Ailus
2024-04-30 7:23 ` Jacopo Mondi
2024-04-30 7:31 ` Sakari Ailus [this message]
2024-04-29 19:08 ` [PATCH v4 4/4] media: ivsc: csi: Obtain link frequency from the media pad Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjCeNcF1nkt6WKUS@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=wentong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).