From: Sakari Ailus <sakari.ailus@linux.intel.com>
To: Jacopo Mondi <jacopo.mondi@ideasonboard.com>
Cc: linux-media@vger.kernel.org, hverkuil@xs4all.nl,
laurent.pinchart@ideasonboard.com,
Wentong Wu <wentong.wu@intel.com>
Subject: Re: [PATCH v4 1/4] media: v4l: Support passing sub-device argument to v4l2_get_link_freq()
Date: Tue, 30 Apr 2024 07:27:22 +0000 [thread overview]
Message-ID: <ZjCdWg9jnA3XAo5d@kekkonen.localdomain> (raw)
In-Reply-To: <n5gr2rsxbnot7vittbs4mbhsuzmtwqgwlrbzk4ug6yklqyfit5@ts5oyzcc5qpc>
Hi Jacopo,
Thanks for the review.
On Tue, Apr 30, 2024 at 09:01:09AM +0200, Jacopo Mondi wrote:
> Hi Sakari
>
> On Mon, Apr 29, 2024 at 10:08:49PM +0300, Sakari Ailus wrote:
> > v4l2_get_link_freq() accepts a V4L2 control handler for now, but it needs
> > to take struct v4l2_subdev argument in order to obtain the link frequency
This should have been media_pad actually. I'll update the text for v5 (same
in the subject).
> > using get_mbus_config() pad op. Prepare for this by allowing struct
> > v4l2_subdev as well.
> >
> > Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
>
> Nice! I need exactly something like this to avoid pre-computing a lot
> a frequencies in a driver I'm working on.
>
> > ---
> > drivers/media/v4l2-core/v4l2-common.c | 19 ++++++++++++++++---
> > include/media/v4l2-common.h | 14 +++++++++++---
> > 2 files changed, 27 insertions(+), 6 deletions(-)
> >
> > diff --git a/drivers/media/v4l2-core/v4l2-common.c b/drivers/media/v4l2-core/v4l2-common.c
> > index 4165c815faef..7f69b5a025fa 100644
> > --- a/drivers/media/v4l2-core/v4l2-common.c
> > +++ b/drivers/media/v4l2-core/v4l2-common.c
> > @@ -464,8 +464,8 @@ int v4l2_fill_pixfmt(struct v4l2_pix_format *pixfmt, u32 pixelformat,
> > }
> > EXPORT_SYMBOL_GPL(v4l2_fill_pixfmt);
> >
> > -s64 v4l2_get_link_freq(struct v4l2_ctrl_handler *handler, unsigned int mul,
> > - unsigned int div)
> > +s64 __v4l2_get_link_freq_ctrl(struct v4l2_ctrl_handler *handler,
> > + unsigned int mul, unsigned int div)
> > {
> > struct v4l2_ctrl *ctrl;
> > s64 freq;
> > @@ -500,7 +500,20 @@ s64 v4l2_get_link_freq(struct v4l2_ctrl_handler *handler, unsigned int mul,
> >
> > return freq > 0 ? freq : -EINVAL;
> > }
> > -EXPORT_SYMBOL_GPL(v4l2_get_link_freq);
> > +EXPORT_SYMBOL_GPL(__v4l2_get_link_freq_ctrl);
> > +
> > +s64 __v4l2_get_link_freq_pad(struct media_pad *pad, unsigned int mul,
> > + unsigned int div)
> > +{
> > + struct v4l2_subdev *sd;
> > +
> > + sd = media_entity_to_v4l2_subdev(pad->entity);
> > + if (!sd)
> > + return -ENODEV;
> > +
> > + return __v4l2_get_link_freq_ctrl(sd->ctrl_handler, mul, div);
> > +}
> > +EXPORT_SYMBOL_GPL(__v4l2_get_link_freq_pad);
> >
> > /*
> > * Simplify a fraction using a simple continued fraction decomposition. The
> > diff --git a/include/media/v4l2-common.h b/include/media/v4l2-common.h
> > index 63ad36f04f72..d7115cd61a38 100644
> > --- a/include/media/v4l2-common.h
> > +++ b/include/media/v4l2-common.h
> > @@ -525,7 +525,8 @@ int v4l2_fill_pixfmt_mp(struct v4l2_pix_format_mplane *pixfmt, u32 pixelformat,
> > /**
> > * v4l2_get_link_freq - Get link rate from transmitter
> > *
> > - * @handler: The transmitter's control handler
> > + * @pad: The transmitter's media pad (or control handler for compatibility
> > + * reasons, don't use in new code)
> > * @mul: The multiplier between pixel rate and link frequency. Bits per pixel on
> > * D-PHY, samples per clock on parallel. 0 otherwise.
> > * @div: The divisor between pixel rate and link frequency. Number of data lanes
> > @@ -541,8 +542,15 @@ int v4l2_fill_pixfmt_mp(struct v4l2_pix_format_mplane *pixfmt, u32 pixelformat,
> > * * %-ENOENT: Link frequency or pixel rate control not found
> > * * %-EINVAL: Invalid link frequency value
> > */
> > -s64 v4l2_get_link_freq(struct v4l2_ctrl_handler *handler, unsigned int mul,
> > - unsigned int div);
> > +#define v4l2_get_link_freq(pad, mul, div) \
> > + _Generic(pad, \
> > + struct media_pad *: __v4l2_get_link_freq_pad, \
> > + struct v4l2_ctrl_handler *: __v4l2_get_link_freq_ctrl) \
> > + (pad, mul, div)
>
> That's nice and elegant, but given that I count 10 drivers in mainline
> using this function, wouldn't it be better to make them use a pad and
> remove the ctrl_handler version completely to avoid it being used in
> future ?
It'd be nice to add a function that takes the CSI-2 configuration from the
endpoint as well, doing this manually in drivers is awkward and a lot of
extra code. I'm all for this but I'd do this separately, after which we can
remove the above macro.
Note that for the IVSC driver this is a bugfix.
>
> > +s64 __v4l2_get_link_freq_pad(struct media_pad *pad, unsigned int mul,
> > + unsigned int div);
> > +s64 __v4l2_get_link_freq_ctrl(struct v4l2_ctrl_handler *handler,
> > + unsigned int mul, unsigned int div);
> >
> > void v4l2_simplify_fraction(u32 *numerator, u32 *denominator,
> > unsigned int n_terms, unsigned int threshold);
--
Kind regards,
Sakari Ailus
next prev parent reply other threads:[~2024-04-30 7:27 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 19:08 [PATCH v4 0/4] Use V4L2 mbus config for conveying MEI CSI link frequency Sakari Ailus
2024-04-29 19:08 ` [PATCH v4 1/4] media: v4l: Support passing sub-device argument to v4l2_get_link_freq() Sakari Ailus
2024-04-30 7:01 ` Jacopo Mondi
2024-04-30 7:27 ` Sakari Ailus [this message]
2024-04-29 19:08 ` [PATCH v4 2/4] media: v4l: Support obtaining link frequency via get_mbus_config Sakari Ailus
2024-04-30 7:19 ` Jacopo Mondi
2024-04-30 7:29 ` Sakari Ailus
2024-04-29 19:08 ` [PATCH v4 3/4] media: Documentation: Update link frequency driver documentation Sakari Ailus
2024-04-30 7:23 ` Jacopo Mondi
2024-04-30 7:31 ` Sakari Ailus
2024-04-29 19:08 ` [PATCH v4 4/4] media: ivsc: csi: Obtain link frequency from the media pad Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZjCdWg9jnA3XAo5d@kekkonen.localdomain \
--to=sakari.ailus@linux.intel.com \
--cc=hverkuil@xs4all.nl \
--cc=jacopo.mondi@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=wentong.wu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).