From: Jani Nikula <jani.nikula@linux.intel.com>
To: Rodrigo Vivi <rodrigo.vivi@intel.com>,
Easwar Hariharan <eahariha@linux.microsoft.com>
Cc: Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
Tvrtko Ursulin <tursulin@ursulin.net>,
David Airlie <airlied@gmail.com>, Daniel Vetter <daniel@ffwll.ch>,
Zhenyu Wang <zhenyuw@linux.intel.com>,
Zhi Wang <zhi.wang.linux@gmail.com>,
"open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
<intel-gfx@lists.freedesktop.org>,
"open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
<intel-xe@lists.freedesktop.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
open list <linux-kernel@vger.kernel.org>,
"open list:INTEL GVT-g DRIVERS (Intel GPU Virtualization)"
<intel-gvt-dev@lists.freedesktop.org>,
Wolfram Sang <wsa+renesas@sang-engineering.com>,
"open list:RADEON and AMDGPU DRM DRIVERS"
<amd-gfx@lists.freedesktop.org>,
"open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
<nouveau@lists.freedesktop.org>,
"open list:I2C SUBSYSTEM HOST DRIVERS"
<linux-i2c@vger.kernel.org>,
"open list:BTTV VIDEO4LINUX DRIVER" <linux-media@vger.kernel.org>,
"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>,
Zhi Wang <zhiwang@kernel.org>
Subject: Re: [PATCH v2 03/12] drm/i915: Make I2C terminology more inclusive
Date: Mon, 06 May 2024 12:06:41 +0300 [thread overview]
Message-ID: <87seyvnwbi.fsf@intel.com> (raw)
In-Reply-To: <ZjVTqNGjaAjuLdLi@intel.com>
On Fri, 03 May 2024, Rodrigo Vivi <rodrigo.vivi@intel.com> wrote:
> On Fri, May 03, 2024 at 02:04:15PM -0700, Easwar Hariharan wrote:
>> On 5/3/2024 12:34 PM, Rodrigo Vivi wrote:
>> > On Fri, May 03, 2024 at 06:13:24PM +0000, Easwar Hariharan wrote:
>> >> I2C v7, SMBus 3.2, and I3C 1.1.1 specifications have replaced "master/slave"
>> >> with more appropriate terms. Inspired by and following on to Wolfram's
>> >> series to fix drivers/i2c/[1], fix the terminology for users of
>> >> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
>> >> in the specification.
>> >>
>> >> Compile tested, no functionality changes intended
>> >>
>> >> [1]: https://lore.kernel.org/all/20240322132619.6389-1-wsa+renesas@sang-engineering.com/
>> >>
>> >> Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> >> Acked-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
>> >
>> > It looks like the ack is not needed since we are merging this through
>> > drm-intel-next. But I'm planing to merge this only after seeing the
>> > main drivers/i2c accepting the new terminology. So we don't have a
>> > risk of that getting push back and new names there and we having
>> > to rename it once again.
>>
>> Just to be explicit, did you want me to remove the Acked-by in v3, or will you when you pull
>> the patch into drm-intel-next?
>>
>> >
>> > (more below)
>> >
>> >> Acked-by: Zhi Wang <zhiwang@kernel.org>
>> >> Signed-off-by: Easwar Hariharan <eahariha@linux.microsoft.com>
>> >
>> > Cc: Jani Nikula <jani.nikula@intel.com>
>> >
>> > Jani, what bits were you concerned that were not necessarily i2c?
>> > I believe although not necessarily/directly i2c, I believe they
>> > are related and could benefit from the massive single shot renable.
>> > or do you have any better split to suggest here?
>> >
>> > (more below)
>> >
>> >> ---
>> >> drivers/gpu/drm/i915/display/dvo_ch7017.c | 14 ++++-----
>> >> drivers/gpu/drm/i915/display/dvo_ch7xxx.c | 18 +++++------
>> >> drivers/gpu/drm/i915/display/dvo_ivch.c | 16 +++++-----
>> >> drivers/gpu/drm/i915/display/dvo_ns2501.c | 18 +++++------
>> >> drivers/gpu/drm/i915/display/dvo_sil164.c | 18 +++++------
>> >> drivers/gpu/drm/i915/display/dvo_tfp410.c | 18 +++++------
>> >> drivers/gpu/drm/i915/display/intel_bios.c | 22 +++++++-------
>> >> drivers/gpu/drm/i915/display/intel_ddi.c | 2 +-
>> >> .../gpu/drm/i915/display/intel_display_core.h | 2 +-
>> >> drivers/gpu/drm/i915/display/intel_dsi.h | 2 +-
>> >> drivers/gpu/drm/i915/display/intel_dsi_vbt.c | 20 ++++++-------
>> >> drivers/gpu/drm/i915/display/intel_dvo.c | 14 ++++-----
>> >> drivers/gpu/drm/i915/display/intel_dvo_dev.h | 2 +-
>> >> drivers/gpu/drm/i915/display/intel_gmbus.c | 4 +--
>> >> drivers/gpu/drm/i915/display/intel_sdvo.c | 30 +++++++++----------
>> >> drivers/gpu/drm/i915/display/intel_vbt_defs.h | 4 +--
>> >> drivers/gpu/drm/i915/gvt/edid.c | 28 ++++++++---------
>> >> drivers/gpu/drm/i915/gvt/edid.h | 4 +--
>> >> drivers/gpu/drm/i915/gvt/opregion.c | 2 +-
>> >> 19 files changed, 119 insertions(+), 119 deletions(-)
>> >>
>>
>> <snip>
>>
>> >> diff --git a/drivers/gpu/drm/i915/display/intel_ddi.c b/drivers/gpu/drm/i915/display/intel_ddi.c
>> >> index c17462b4c2ac..64db211148a8 100644
>> >> --- a/drivers/gpu/drm/i915/display/intel_ddi.c
>> >> +++ b/drivers/gpu/drm/i915/display/intel_ddi.c
>> >> @@ -4332,7 +4332,7 @@ static int intel_ddi_compute_config_late(struct intel_encoder *encoder,
>> >> connector->tile_group->id);
>> >>
>> >> /*
>> >> - * EDP Transcoders cannot be ensalved
>> >> + * EDP Transcoders cannot be slaves
>> >
>> > ^ here
>> > perhaps you meant 'targeted' ?
>> >
>> >> * make them a master always when present
>>
>> <snip>
>>
>> This is not actually I2C related as far as I could tell when I was making the change, so this was more of a typo fix.
>>
>> If we want to improve this, a quick check with the eDP v1.5a spec suggests using primary/secondary instead,
>> though in a global fashion rather than specifically for eDP transcoders. There is also source/sink terminology
>> in the spec related to DP encoders.
>>
>> Which would be a more acceptable change here?
>
> hmmm probably better to split the patches and align with the spec naming where it applies.
> and with i2c name where it applies.
Yeah this one is completely unrelated to i2c and aux, and what the eDP
spec says is irrelevant here. This should follow Intel hw specs.
BR,
Jani.
--
Jani Nikula, Intel
next prev parent reply other threads:[~2024-05-06 9:06 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-03 18:13 [PATCH v2 00/12] Make I2C terminology more inclusive for I2C Algobit and consumers Easwar Hariharan
2024-05-03 18:13 ` [PATCH v2 01/12] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive Easwar Hariharan
2024-05-07 18:16 ` Easwar Hariharan
2024-05-08 14:53 ` Alex Deucher
2024-05-08 20:12 ` Easwar Hariharan
2024-05-08 21:12 ` Alex Deucher
2024-05-03 18:13 ` [PATCH v2 02/12] drm/gma500: " Easwar Hariharan
2024-05-03 18:13 ` [PATCH v2 03/12] drm/i915: " Easwar Hariharan
2024-05-03 19:34 ` Rodrigo Vivi
2024-05-03 21:04 ` Easwar Hariharan
2024-05-03 21:14 ` Rodrigo Vivi
2024-05-06 9:06 ` Jani Nikula [this message]
2024-05-06 9:17 ` Andi Shyti
2024-05-03 18:13 ` [PATCH v2 04/12] media: au0828: " Easwar Hariharan
2024-05-03 18:13 ` [PATCH v2 05/12] media: cobalt: " Easwar Hariharan
2024-05-03 18:13 ` [PATCH v2 06/12] media: cx18: " Easwar Hariharan
2024-05-03 18:13 ` [PATCH v2 07/12] media: cx25821: " Easwar Hariharan
2024-05-03 18:13 ` [PATCH v2 08/12] media: ivtv: " Easwar Hariharan
2024-05-03 18:13 ` [PATCH v2 09/12] media: cx23885: " Easwar Hariharan
2024-05-03 18:13 ` [PATCH v2 10/12] sfc: falcon: " Easwar Hariharan
2024-05-03 18:13 ` [PATCH v2 11/12] fbdev/smscufx: " Easwar Hariharan
2024-05-06 9:21 ` Thomas Zimmermann
2024-05-03 18:13 ` [PATCH v2 12/12] fbdev/viafb: " Easwar Hariharan
2024-05-06 9:22 ` Thomas Zimmermann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87seyvnwbi.fsf@intel.com \
--to=jani.nikula@linux.intel.com \
--cc=airlied@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=daniel@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=eahariha@linux.microsoft.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=intel-gvt-dev@lists.freedesktop.org \
--cc=intel-xe@lists.freedesktop.org \
--cc=joonas.lahtinen@linux.intel.com \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=nouveau@lists.freedesktop.org \
--cc=rodrigo.vivi@intel.com \
--cc=tursulin@ursulin.net \
--cc=wsa+renesas@sang-engineering.com \
--cc=zhenyuw@linux.intel.com \
--cc=zhi.wang.linux@gmail.com \
--cc=zhiwang@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).