From: Jacopo Mondi <jacopo+renesas@jmondi.org>
To: tomi.valkeinen@ideasonboard.com, sakari.ailus@linux.intel.com,
laurent.pinchart@ideasonboard.com, niklas.soderlund@ragnatech.se,
kieran.bingham@ideasonboard.com
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: [PATCH v4 2/6] media: max9286: Implement set_routing
Date: Thu, 16 Dec 2021 18:47:42 +0100 [thread overview]
Message-ID: <20211216174746.147233-3-jacopo+renesas@jmondi.org> (raw)
In-Reply-To: <20211216174746.147233-1-jacopo+renesas@jmondi.org>
Add the set_routing() subdev operation to allow userspace to configure
routing on the max9286 deserializer.
Implement route verification but do not take routing into consideration
when configuring the CSI-2 output and pixel rate yet.
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
drivers/media/i2c/max9286.c | 89 ++++++++++++++++++++++++++++++++++++-
1 file changed, 87 insertions(+), 2 deletions(-)
diff --git a/drivers/media/i2c/max9286.c b/drivers/media/i2c/max9286.c
index 1b9ff537d08e..eb76acdb2cd9 100644
--- a/drivers/media/i2c/max9286.c
+++ b/drivers/media/i2c/max9286.c
@@ -832,6 +832,91 @@ static int max9286_get_fmt(struct v4l2_subdev *sd,
return 0;
}
+static int max9286_routing_validate(struct max9286_priv *priv,
+ struct v4l2_subdev_krouting *routing)
+{
+ unsigned int i;
+ int ret;
+
+ ret = v4l2_subdev_routing_validate_1_to_1(routing);
+ if (ret)
+ return ret;
+
+ /*
+ * Make sure all routes points to the single source pad which can have
+ * up to 4 streams. All routes shall start from a sink pad and shall not
+ * have more than one sink stream. The GMSL link for the sink has to be
+ * enabled.
+ */
+ for (i = 0; i < routing->num_routes; ++i) {
+ const struct v4l2_subdev_route *route = &routing->routes[i];
+ struct max9286_source *source = &priv->sources[i];
+
+ if (route->source_pad != MAX9286_SRC_PAD ||
+ route->source_stream > 4) {
+ dev_err(&priv->client->dev,
+ "Invalid (%u,%u) source in route %u\n",
+ route->source_pad, route->source_stream, i);
+ return -EINVAL;
+ }
+
+ if (route->sink_pad >= MAX9286_N_SINKS ||
+ route->sink_stream != 0) {
+ dev_err(&priv->client->dev,
+ "Invalid (%u,%u) sink in route %u\n",
+ route->sink_pad, route->sink_stream, i);
+ return -EINVAL;
+ }
+
+ source = &priv->sources[route->sink_pad];
+ if (!source->fwnode) {
+ dev_err(&priv->client->dev,
+ "Cannot set route for non-active source %u\n",
+ route->sink_pad);
+ return -EINVAL;
+ }
+ }
+
+ return 0;
+}
+
+static int _max9286_set_routing(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *state,
+ struct v4l2_subdev_krouting *routing)
+{
+ struct max9286_priv *priv = sd_to_max9286(sd);
+ int ret;
+
+ ret = max9286_routing_validate(priv, routing);
+ if (ret)
+ return ret;
+
+ /* Re-initialize the format on a routing change. */
+ ret = v4l2_subdev_set_routing_with_fmt(sd, state, routing,
+ &max9286_default_format);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+
+static int max9286_set_routing(struct v4l2_subdev *sd,
+ struct v4l2_subdev_state *state,
+ enum v4l2_subdev_format_whence which,
+ struct v4l2_subdev_krouting *routing)
+{
+ struct max9286_priv *priv = sd_to_max9286(sd);
+ unsigned int i;
+ int ret;
+
+ v4l2_subdev_lock_state(state);
+
+ ret = _max9286_set_routing(sd, state, routing);
+ v4l2_subdev_unlock_state(state);
+
+ return ret;
+}
+
static int max9286_init_cfg(struct v4l2_subdev *sd,
struct v4l2_subdev_state *state)
{
@@ -858,8 +943,7 @@ static int max9286_init_cfg(struct v4l2_subdev *sd,
routing.routes = routes;
v4l2_subdev_lock_state(state);
- ret = v4l2_subdev_set_routing_with_fmt(sd, state, &routing,
- &max9286_default_format);
+ ret = _max9286_set_routing(sd, state, &routing);
v4l2_subdev_unlock_state(state);
return ret;
@@ -874,6 +958,7 @@ static const struct v4l2_subdev_pad_ops max9286_pad_ops = {
.enum_mbus_code = max9286_enum_mbus_code,
.get_fmt = max9286_get_fmt,
.set_fmt = max9286_set_fmt,
+ .set_routing = max9286_set_routing,
};
static const struct v4l2_subdev_ops max9286_subdev_ops = {
--
2.33.1
next prev parent reply other threads:[~2021-12-16 17:47 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-12-16 17:47 [PATCH v4 0/6] media: max9286: Add multiplexed streams support Jacopo Mondi
2021-12-16 17:47 ` [PATCH v4 1/6] media: max9286: Add support for v4l2_subdev_state Jacopo Mondi
2021-12-16 18:33 ` Laurent Pinchart
2021-12-16 17:47 ` Jacopo Mondi [this message]
2021-12-17 1:56 ` [PATCH v4 2/6] media: max9286: Implement set_routing Laurent Pinchart
2021-12-17 2:18 ` Laurent Pinchart
2021-12-17 2:24 ` Laurent Pinchart
2021-12-17 13:28 ` Jacopo Mondi
2021-12-16 17:47 ` [PATCH v4 3/6] media: max9286: Use enabled routes to calculate pixelrate Jacopo Mondi
2021-12-17 2:29 ` Laurent Pinchart
2021-12-17 13:32 ` Jacopo Mondi
2021-12-16 17:47 ` [PATCH v4 4/6] media: max9286: Use routes to configure link order Jacopo Mondi
2021-12-17 2:35 ` Laurent Pinchart
2021-12-17 13:38 ` Jacopo Mondi
2021-12-16 17:47 ` [PATCH v4 5/6] media: max9286: Move format to subdev state Jacopo Mondi
2021-12-17 2:40 ` Laurent Pinchart
2021-12-17 3:09 ` Laurent Pinchart
2021-12-17 14:11 ` Jacopo Mondi
2024-05-09 13:11 ` Laurent Pinchart
2021-12-16 17:47 ` [PATCH v4 6/6] media: max9286: Implement get_frame_desc() Jacopo Mondi
2021-12-17 2:45 ` Laurent Pinchart
2021-12-17 14:12 ` Jacopo Mondi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20211216174746.147233-3-jacopo+renesas@jmondi.org \
--to=jacopo+renesas@jmondi.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=kieran.bingham@ideasonboard.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=sakari.ailus@linux.intel.com \
--cc=tomi.valkeinen@ideasonboard.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).