From: swarup <swarupkotikalapudi@gmail.com>
To: Paolo Abeni <pabeni@redhat.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
jiri@resnulli.us, netdev@vger.kernel.org,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] netlink: specs: devlink: add missing attributes in devlink.yaml and re-generate the related code
Date: Tue, 14 Nov 2023 16:14:27 +0530 [thread overview]
Message-ID: <ZVNPi7pmJIDJ6Ms7@swarup-virtual-machine> (raw)
In-Reply-To: <0d902d2b15ef44e9e0157d8012c42347ffeec86e.camel@redhat.com>
eOn Tue, Nov 14, 2023 at 10:45:23AM +0100, Paolo Abeni wrote:
> On Mon, 2023-11-13 at 12:09 +0530, Swarup Laxman Kotiaklapudi wrote:
> > Add missing attributes in devlink.yaml.
> >
> > Re-generate the related devlink-user.[ch] code.
> >
> > trap-get command prints nested attributes.
> >
> > Test result with trap-get command:
> >
> > sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/devlink.yaml
> > --do trap-get --json '{"bus-name": "netdevsim", "dev-name": "netdevsim1",
> > "trap-name": "ttl_value_is_too_small"}' --process-unknown
> >
> > {'attr-stats': {'rx-bytes': 30931292, 'rx-dropped': 87,
> > 'rx-packets': 217826},
> > 'bus-name': 'netdevsim',
> > 'dev-name': 'netdevsim1',
> > 'trap-action': 'trap',
> > 'trap-generic': True,
> > 'trap-group-name': 'l3_exceptions',
> > 'trap-metadata': {'metadata-type-in-port': True},
> > 'trap-name': 'ttl_value_is_too_small',
> > 'trap-type': 'exception'}
> >
> > Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
> > Suggested-by: Jiri Pirko <jiri@resnulli.us>
>
> Please insert the target tree in the subj prefix (in this case 'net-
> next')
>
> Does not apply cleanly to net-next, please rebase it.
>
> Thanks,
>
> Paolo
>
Hi Paolo,
I have some emergency,
hence will not have access to computer for next 2-3 days,
once i am back, i will rebase and submit the patch again.
Thanks,
Swarup
next prev parent reply other threads:[~2023-11-14 10:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-13 6:39 [PATCH] netlink: specs: devlink: add missing attributes in devlink.yaml and re-generate the related code Swarup Laxman Kotiaklapudi
2023-11-14 9:45 ` Paolo Abeni
2023-11-14 10:44 ` swarup [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-12 9:23 Swarup Laxman Kotiaklapudi
2023-11-12 20:46 ` Jakub Kicinski
2023-11-13 11:40 ` Jiri Pirko
2023-11-13 11:44 ` Jiri Pirko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVNPi7pmJIDJ6Ms7@swarup-virtual-machine \
--to=swarupkotikalapudi@gmail.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jiri@resnulli.us \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).