From: Jiri Pirko <jiri@resnulli.us>
To: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
Cc: davem@davemloft.net, edumazet@google.com, kuba@kernel.org,
pabeni@redhat.com,
linux-kernel-mentees@lists.linuxfoundation.org
Subject: Re: [PATCH] netlink: specs: devlink: add missing attributes in devlink.yaml and re-generate the related code
Date: Mon, 13 Nov 2023 12:44:10 +0100 [thread overview]
Message-ID: <ZVIMCnimkdpyi5IY@nanopsycho> (raw)
In-Reply-To: <20231112092352.20072-1-swarupkotikalapudi@gmail.com>
Sun, Nov 12, 2023 at 10:23:52AM CET, swarupkotikalapudi@gmail.com wrote:
>Add missing attributes in devlink.yaml.
>
>Re-generate the related devlink-user.[ch] code.
>
>trap-get command prints nested attributes.
>
>Test result with trap-get command:
trap is just an example of command that din't have all attrs defines.
But there are many others. Adjust your patch description accordingly
please. Now it looks like this is about trap only.
>
>sudo ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/devlink.yaml
>--do trap-get --json '{"bus-name": "netdevsim", "dev-name": "netdevsim1",
>"trap-name": "ttl_value_is_too_small"}' --process-unknown
>
>{'attr-stats': {'rx-bytes': 30931292, 'rx-dropped': 87,
> 'rx-packets': 217826},
> 'bus-name': 'netdevsim',
> 'dev-name': 'netdevsim1',
> 'trap-action': 'trap',
> 'trap-generic': True,
> 'trap-group-name': 'l3_exceptions',
> 'trap-metadata': {'metadata-type-in-port': True},
> 'trap-name': 'ttl_value_is_too_small',
> 'trap-type': 'exception'}
>
>Signed-off-by: Swarup Laxman Kotiaklapudi <swarupkotikalapudi@gmail.com>
>Suggested-by: Jiri Pirko <jiri@resnulli.us>
[..]
next prev parent reply other threads:[~2023-11-13 11:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-11-12 9:23 [PATCH] netlink: specs: devlink: add missing attributes in devlink.yaml and re-generate the related code Swarup Laxman Kotiaklapudi
2023-11-12 20:46 ` Jakub Kicinski
2023-11-13 11:40 ` Jiri Pirko
2023-11-13 11:44 ` Jiri Pirko [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-11-13 6:39 Swarup Laxman Kotiaklapudi
2023-11-14 9:45 ` Paolo Abeni
2023-11-14 10:44 ` swarup
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZVIMCnimkdpyi5IY@nanopsycho \
--to=jiri@resnulli.us \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=kuba@kernel.org \
--cc=linux-kernel-mentees@lists.linuxfoundation.org \
--cc=pabeni@redhat.com \
--cc=swarupkotikalapudi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).