From: "Datta, Shubhrajyoti" <shubhrajyoti.datta@amd.com>
To: Borislav Petkov <bp@alien8.de>
Cc: Dan Carpenter <dan.carpenter@linaro.org>,
"linux-edac@vger.kernel.org" <linux-edac@vger.kernel.org>
Subject: RE: [bug report] EDAC/versal: Add a Xilinx Versal memory controller driver
Date: Tue, 24 Oct 2023 09:29:09 +0000 [thread overview]
Message-ID: <BY5PR12MB4902A572453E8913F886C77281DFA@BY5PR12MB4902.namprd12.prod.outlook.com> (raw)
In-Reply-To: <20231024092554.GAZTeNoqT7HQQzb08U@fat_crate.local>
[AMD Official Use Only - General]
> -----Original Message-----
> From: Borislav Petkov <bp@alien8.de>
> Sent: Tuesday, October 24, 2023 2:56 PM
> To: Datta, Shubhrajyoti <shubhrajyoti.datta@amd.com>
> Cc: Dan Carpenter <dan.carpenter@linaro.org>; linux-edac@vger.kernel.org
> Subject: Re: [bug report] EDAC/versal: Add a Xilinx Versal memory controller
> driver
>
> Caution: This message originated from an External Source. Use proper
> caution when opening attachments, clicking links, or responding.
>
>
> On Tue, Oct 24, 2023 at 05:43:59AM +0000, Datta, Shubhrajyoti wrote:
> > Thanks sent the patch.
>
> This is not how this works: you either agree with the diff and reply with an
> Acked-by or you don't agree and you say why.
>
> What you don't do is take someone else's diff and slap your name on it
> without asking for permission first.
>
> Take some time to read about the development process in
> Documentation/process/ to get acquainted with how Linux development
> works.
My bad. I misunderstood.
>
> > > I guess something like this ontop:
> > >
> > > diff --git a/drivers/edac/versal_edac.c b/drivers/edac/versal_edac.c
> > > index
> > > 08f630185913..87e730dfefa0 100644
> > > --- a/drivers/edac/versal_edac.c
> > > +++ b/drivers/edac/versal_edac.c
> > > @@ -962,10 +962,8 @@ static int mc_probe(struct platform_device
> *pdev)
> > > if (!get_ecc_state(ddrmc_baseaddr))
> > > return -ENXIO;
> > >
> > > - /* Allocate ID number for our EMIF controller */
> > > + /* Allocate ID number for the EMIF controller */
> > > edac_mc_id = emif_get_id(pdev->dev.of_node);
> > > - if (edac_mc_id < 0)
> > > - return -EINVAL;
> > >
> > > regval = readl(ddrmc_baseaddr + XDDR_REG_CONFIG0_OFFSET);
> > > num_chans =
> FIELD_PREP(XDDR_REG_CONFIG0_NUM_CHANS_MASK,
> > > regval);
>
> As to this - I already merged it with the driver patch as it was the topmost
> one on the branch.
Thanks.
But anyways feel free to add my
Acked-by: Shubhrajyoti Datta <shubhrajyoti.datta@amd.com>
>
> --
> Regards/Gruss,
> Boris.
>
> https://people.kernel.org/tglx/notes-about-netiquette
prev parent reply other threads:[~2023-10-24 9:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-20 13:45 [bug report] EDAC/versal: Add a Xilinx Versal memory controller driver Dan Carpenter
2023-10-20 15:41 ` Borislav Petkov
2023-10-24 5:43 ` Datta, Shubhrajyoti
2023-10-24 9:25 ` Borislav Petkov
2023-10-24 9:29 ` Datta, Shubhrajyoti [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=BY5PR12MB4902A572453E8913F886C77281DFA@BY5PR12MB4902.namprd12.prod.outlook.com \
--to=shubhrajyoti.datta@amd.com \
--cc=bp@alien8.de \
--cc=dan.carpenter@linaro.org \
--cc=linux-edac@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).