From: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>
To: Borislav Petkov <bp@alien8.de>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-edac@vger.kernel.org,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [RFC PATCH v2 3/3] ACPI: extlog: Make print_extlog_rcd() log unconditionally
Date: Fri, 10 May 2024 21:00:34 +0200 [thread overview]
Message-ID: <7009544.jJDZkT8p0M@fdefranc-mobl3> (raw)
In-Reply-To: <20240510125214.GCZj4YfluoP-mDz3_U@fat_crate.local>
On Friday, May 10, 2024 2:52:14 PM GMT+2 Borislav Petkov wrote:
> On Fri, May 10, 2024 at 01:21:47PM +0200, Fabio M. De Francesco wrote:
> > Make extlog_print_rcd() log unconditionally to report errors even if
> > userspace is not consuming trace events. Remove ras_userspace_consumers()
> > because it is not anymore used.
>
> Did you do any git archeology before that?
>
> d6cae935ec5b ("trace, eMCA: Add a knob to adjust where to save event log")
>
> I can't find in this commit message why this is needed... Do share pls.
>
> > This change makes extlog_print() (ELOG) log consistently with ghes_proc()
> > (GHES).
I thought that ELOG and GHES should be modeled consistently. ghes_proc()
prints to the console while ghes_do_proc() also uses ftrace. I made this short
series an RFC mainly to ask / receive comments on this change (3/3).
If we want to make ELOG and GHES act similarly, this patch is needed.
Otherwise, things should be left the way they currently are.
I'll make a v3 with a more clear explanation of why I think we should prefer
to make ELOG act similarly to GHES in how kernel logs are handled.
> Avoid having "This patch" or "This commit" in the commit message. It is
> tautologically useless.
>
> Also, do
>
> $ git grep 'This patch' Documentation/process
>
> for more details.
>
> Pls have a look at our documentation and check all your patches.
>
> Thx.
Please note that I was introducing the "why" part of the message. I never
refer to this patch for the "what", and I always use an imperative tone only
in the "what" part.
However, I see why this commit message was poor. And probably also the other
two were low quality. Therefore, I'll rework this and also the other two
messages.
Thanks for your comments,
Fabio
next prev parent reply other threads:[~2024-05-10 19:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 11:21 [RFC PATCH v2 0/3] Make ELOG log and trace consistently with GHES Fabio M. De Francesco
2024-05-10 11:21 ` [RFC PATCH v2 1/3] ACPI: extlog: Trace CPER Non-standard Section Body Fabio M. De Francesco
2024-05-10 11:21 ` [RFC PATCH v2 2/3] ACPI: extlog: Trace CPER PCI Express Error Section Fabio M. De Francesco
2024-05-21 19:58 ` Dan Williams
2024-05-10 11:21 ` [RFC PATCH v2 3/3] ACPI: extlog: Make print_extlog_rcd() log unconditionally Fabio M. De Francesco
2024-05-10 12:52 ` Borislav Petkov
2024-05-10 19:00 ` Fabio M. De Francesco [this message]
2024-05-10 19:25 ` Borislav Petkov
2024-05-10 20:54 ` Fabio M. De Francesco
2024-05-10 22:12 ` Dan Williams
2024-05-11 13:08 ` Borislav Petkov
2024-05-12 23:45 ` Dan Williams
2024-05-16 9:57 ` Borislav Petkov
2024-05-16 18:56 ` Dan Williams
2024-05-16 20:03 ` Luck, Tony
2024-05-17 21:43 ` Dan Williams
2024-05-21 18:39 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7009544.jJDZkT8p0M@fdefranc-mobl3 \
--to=fabio.m.de.francesco@linux.intel.com \
--cc=bp@alien8.de \
--cc=dan.j.williams@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).