From: Dan Williams <dan.j.williams@intel.com>
To: "Fabio M. De Francesco" <fabio.m.de.francesco@linux.intel.com>,
"Borislav Petkov" <bp@alien8.de>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Len Brown <lenb@kernel.org>, Tony Luck <tony.luck@intel.com>,
<linux-acpi@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-edac@vger.kernel.org>,
Dan Williams <dan.j.williams@intel.com>
Subject: Re: [RFC PATCH v2 3/3] ACPI: extlog: Make print_extlog_rcd() log unconditionally
Date: Fri, 10 May 2024 15:12:36 -0700 [thread overview]
Message-ID: <663e9bd4c2525_db82d29451@dwillia2-xfh.jf.intel.com.notmuch> (raw)
In-Reply-To: <2881368.Ex9A2HvPv6@fdefranc-mobl3>
Fabio M. De Francesco wrote:
> On Friday, May 10, 2024 9:25:56 PM GMT+2 Borislav Petkov wrote:
> > On Fri, May 10, 2024 at 09:00:34PM +0200, Fabio M. De Francesco wrote:
> > > I thought that ELOG and GHES should be modeled consistently. ghes_proc()
> > > prints to the console while ghes_do_proc() also uses ftrace.
> >
> > ghes_proc() calls ghes_do_proc(). I have no clue what you mean here.
> >
>
> My understanding is that ghes_proc() logs to the console and ghes_do_proc()
> calls the tracers.
>
> Therefore, GHES at the same time always reports the errors via two different
> means.
>
> Instead ELOG depends on the check on ras_userspace_consumers() to decide
> whether to call print_extlog_rcd() to print the logs. And if it print to the
> kernel logs, it jumps to "out" and skips the tracers.
>
> Why is it different with respect to how error reporting is made in GHES?
>
> I thought that ELOG should be modeled similarly to GHES and so it should print
> to the kernel logs always unconditionally and then it should also use ftrace
> (no goto "out" and skip tracers).
>
> (1) Is my understanding of logging and tracing in ELOG and GHES correct?
> (2) If it is, does it make sense for ELOG to print to the kernel log,
> unconditionally, and then call the tracers like ghes_proc() + ghes_do_proc()
> do?
I had asked Fabio to take a look at whether it made sense to continue
with the concept of ras_userspace_consumers() especially since it seems
limited to the EXTLOG case.
In general I am finding that between OS Native and Firmware First error
reporting the logging approaches are inconsistent.
As far I can see rasdaemon would not even notice is the "daemon_active"
debugfs file went away [1], and it should be the case that the
tracepoints always fire whether daemon_active is open or not.
So I was expecting this removal to be a conversation starter on the
wider topic of error reporting consistency.
[1]: https://github.com/mchehab/rasdaemon/blob/master/ras-events.c#L992
next prev parent reply other threads:[~2024-05-10 22:12 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-10 11:21 [RFC PATCH v2 0/3] Make ELOG log and trace consistently with GHES Fabio M. De Francesco
2024-05-10 11:21 ` [RFC PATCH v2 1/3] ACPI: extlog: Trace CPER Non-standard Section Body Fabio M. De Francesco
2024-05-10 11:21 ` [RFC PATCH v2 2/3] ACPI: extlog: Trace CPER PCI Express Error Section Fabio M. De Francesco
2024-05-21 19:58 ` Dan Williams
2024-05-10 11:21 ` [RFC PATCH v2 3/3] ACPI: extlog: Make print_extlog_rcd() log unconditionally Fabio M. De Francesco
2024-05-10 12:52 ` Borislav Petkov
2024-05-10 19:00 ` Fabio M. De Francesco
2024-05-10 19:25 ` Borislav Petkov
2024-05-10 20:54 ` Fabio M. De Francesco
2024-05-10 22:12 ` Dan Williams [this message]
2024-05-11 13:08 ` Borislav Petkov
2024-05-12 23:45 ` Dan Williams
2024-05-16 9:57 ` Borislav Petkov
2024-05-16 18:56 ` Dan Williams
2024-05-16 20:03 ` Luck, Tony
2024-05-17 21:43 ` Dan Williams
2024-05-21 18:39 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=663e9bd4c2525_db82d29451@dwillia2-xfh.jf.intel.com.notmuch \
--to=dan.j.williams@intel.com \
--cc=bp@alien8.de \
--cc=fabio.m.de.francesco@linux.intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=tony.luck@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).