From: kernel test robot <lkp@intel.com>
To: Chenghai Huang <huangchenghai2@huawei.com>,
herbert@gondor.apana.org.au, davem@davemloft.net
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org, fanghao11@huawei.com,
liulongfang@huawei.com, shenyang39@huawei.com,
songzhiqi1@huawei.com, qianweili@huawei.com,
liushangbin@hisilicon.com, linwenkai6@hisilicon.com,
taoqi10@huawei.com, wangzhou1@hisilicon.com,
huangchenghai2@huawei.com
Subject: Re: [PATCH 8/9] crypto: hisilicon/debugfs - Resolve the problem of applying for redundant space in sq dump
Date: Thu, 4 Apr 2024 06:57:12 +0800 [thread overview]
Message-ID: <202404040616.cF0Pvb9M-lkp@intel.com> (raw)
In-Reply-To: <20240403100102.2735306-9-huangchenghai2@huawei.com>
Hi Chenghai,
kernel test robot noticed the following build warnings:
[auto build test WARNING on herbert-cryptodev-2.6/master]
[also build test WARNING on herbert-crypto-2.6/master linus/master v6.9-rc2 next-20240403]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Chenghai-Huang/crypto-hisilicon-sec-Add-the-condition-for-configuring-the-sriov-function/20240403-180924
base: https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git master
patch link: https://lore.kernel.org/r/20240403100102.2735306-9-huangchenghai2%40huawei.com
patch subject: [PATCH 8/9] crypto: hisilicon/debugfs - Resolve the problem of applying for redundant space in sq dump
config: arm64-defconfig (https://download.01.org/0day-ci/archive/20240404/202404040616.cF0Pvb9M-lkp@intel.com/config)
compiler: aarch64-linux-gcc (GCC) 13.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240404/202404040616.cF0Pvb9M-lkp@intel.com/reproduce)
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202404040616.cF0Pvb9M-lkp@intel.com/
All warnings (new ones prefixed by >>):
drivers/crypto/hisilicon/debugfs.c: In function 'qm_sq_dump':
>> drivers/crypto/hisilicon/debugfs.c:314:21: warning: unused variable 'sqe_curr' [-Wunused-variable]
314 | void *sqe, *sqe_curr;
| ^~~~~~~~
vim +/sqe_curr +314 drivers/crypto/hisilicon/debugfs.c
94476b2b6d60bc Kai Ye 2022-11-12 310
9c75609842f091 Kai Ye 2022-11-12 311 static int qm_sq_dump(struct hisi_qm *qm, char *s, char *name)
94476b2b6d60bc Kai Ye 2022-11-12 312 {
94476b2b6d60bc Kai Ye 2022-11-12 313 u16 sq_depth = qm->qp_array->cq_depth;
94476b2b6d60bc Kai Ye 2022-11-12 @314 void *sqe, *sqe_curr;
94476b2b6d60bc Kai Ye 2022-11-12 315 struct hisi_qp *qp;
94476b2b6d60bc Kai Ye 2022-11-12 316 u32 qp_id, sqe_id;
94476b2b6d60bc Kai Ye 2022-11-12 317 int ret;
94476b2b6d60bc Kai Ye 2022-11-12 318
94476b2b6d60bc Kai Ye 2022-11-12 319 ret = q_dump_param_parse(qm, s, &sqe_id, &qp_id, sq_depth);
94476b2b6d60bc Kai Ye 2022-11-12 320 if (ret)
94476b2b6d60bc Kai Ye 2022-11-12 321 return ret;
94476b2b6d60bc Kai Ye 2022-11-12 322
e0bbea3a20f7a0 Chenghai Huang 2024-04-03 323 sqe = kzalloc(qm->sqe_size, GFP_KERNEL);
94476b2b6d60bc Kai Ye 2022-11-12 324 if (!sqe)
94476b2b6d60bc Kai Ye 2022-11-12 325 return -ENOMEM;
94476b2b6d60bc Kai Ye 2022-11-12 326
94476b2b6d60bc Kai Ye 2022-11-12 327 qp = &qm->qp_array[qp_id];
e0bbea3a20f7a0 Chenghai Huang 2024-04-03 328 memcpy(sqe, qp->sqe + sqe_id * qm->sqe_size, qm->sqe_size);
e0bbea3a20f7a0 Chenghai Huang 2024-04-03 329 memset(sqe + qm->debug.sqe_mask_offset, QM_SQE_ADDR_MASK,
94476b2b6d60bc Kai Ye 2022-11-12 330 qm->debug.sqe_mask_len);
94476b2b6d60bc Kai Ye 2022-11-12 331
e0bbea3a20f7a0 Chenghai Huang 2024-04-03 332 dump_show(qm, sqe, qm->sqe_size, name);
94476b2b6d60bc Kai Ye 2022-11-12 333
94476b2b6d60bc Kai Ye 2022-11-12 334 kfree(sqe);
94476b2b6d60bc Kai Ye 2022-11-12 335
94476b2b6d60bc Kai Ye 2022-11-12 336 return 0;
94476b2b6d60bc Kai Ye 2022-11-12 337 }
94476b2b6d60bc Kai Ye 2022-11-12 338
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next prev parent reply other threads:[~2024-04-03 22:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 10:00 [PATCH 0/9] crypto: hisilicon - Optimize and fix some driver processes Chenghai Huang
2024-04-03 10:00 ` [PATCH 1/9] crypto: hisilicon/sec - Add the condition for configuring the sriov function Chenghai Huang
2024-04-03 10:00 ` [PATCH 2/9] crypto: hisilicon/debugfs - Fix debugfs uninit process issue Chenghai Huang
2024-04-03 10:00 ` [PATCH 3/9] crypto: hisilicon/sgl - Delete redundant parameter verification Chenghai Huang
2024-04-03 10:00 ` [PATCH 4/9] crypto: hisilicon/debugfs - Fix the processing logic issue in the debugfs creation Chenghai Huang
2024-04-03 10:00 ` [PATCH 5/9] crypto: hisilicon/qm - Add the default processing branch Chenghai Huang
2024-04-03 10:00 ` [PATCH 6/9] crypto: hisilicon - Adjust debugfs creation and release order Chenghai Huang
2024-04-03 10:01 ` [PATCH 7/9] crypto: hisilicon/sec - Fix memory leak for sec resource release Chenghai Huang
2024-04-03 10:01 ` [PATCH 8/9] crypto: hisilicon/debugfs - Resolve the problem of applying for redundant space in sq dump Chenghai Huang
2024-04-03 22:57 ` kernel test robot [this message]
2024-04-03 10:01 ` [PATCH 9/9] crypto: hisilicon/debugfs - Add the err memory release process to qm uninit Chenghai Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202404040616.cF0Pvb9M-lkp@intel.com \
--to=lkp@intel.com \
--cc=davem@davemloft.net \
--cc=fanghao11@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=huangchenghai2@huawei.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linwenkai6@hisilicon.com \
--cc=liulongfang@huawei.com \
--cc=liushangbin@hisilicon.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=qianweili@huawei.com \
--cc=shenyang39@huawei.com \
--cc=songzhiqi1@huawei.com \
--cc=taoqi10@huawei.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).