From: Chenghai Huang <huangchenghai2@huawei.com>
To: <herbert@gondor.apana.org.au>, <davem@davemloft.net>
Cc: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
<fanghao11@huawei.com>, <liulongfang@huawei.com>,
<shenyang39@huawei.com>, <songzhiqi1@huawei.com>,
<qianweili@huawei.com>, <liushangbin@hisilicon.com>,
<linwenkai6@hisilicon.com>, <taoqi10@huawei.com>,
<wangzhou1@hisilicon.com>, <huangchenghai2@huawei.com>
Subject: [PATCH 4/9] crypto: hisilicon/debugfs - Fix the processing logic issue in the debugfs creation
Date: Wed, 3 Apr 2024 18:00:57 +0800 [thread overview]
Message-ID: <20240403100102.2735306-5-huangchenghai2@huawei.com> (raw)
In-Reply-To: <20240403100102.2735306-1-huangchenghai2@huawei.com>
There is a scenario where the file directory is created but the
file attribute is not set. In this case, if a user accesses the
file, an error occurs.
So adjust the processing logic in the debugfs creation to
prevent the file from being accessed before the file attributes
such as the index are set.
Signed-off-by: Chenghai Huang <huangchenghai2@huawei.com>
---
drivers/crypto/hisilicon/debugfs.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/crypto/hisilicon/debugfs.c b/drivers/crypto/hisilicon/debugfs.c
index 6351a452878d..e9fa42381242 100644
--- a/drivers/crypto/hisilicon/debugfs.c
+++ b/drivers/crypto/hisilicon/debugfs.c
@@ -1090,12 +1090,12 @@ static void qm_create_debugfs_file(struct hisi_qm *qm, struct dentry *dir,
{
struct debugfs_file *file = qm->debug.files + index;
- debugfs_create_file(qm_debug_file_name[index], 0600, dir, file,
- &qm_debug_fops);
-
file->index = index;
mutex_init(&file->lock);
file->debug = &qm->debug;
+
+ debugfs_create_file(qm_debug_file_name[index], 0600, dir, file,
+ &qm_debug_fops);
}
static int qm_debugfs_atomic64_set(void *data, u64 val)
--
2.30.0
next prev parent reply other threads:[~2024-04-03 10:05 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-03 10:00 [PATCH 0/9] crypto: hisilicon - Optimize and fix some driver processes Chenghai Huang
2024-04-03 10:00 ` [PATCH 1/9] crypto: hisilicon/sec - Add the condition for configuring the sriov function Chenghai Huang
2024-04-03 10:00 ` [PATCH 2/9] crypto: hisilicon/debugfs - Fix debugfs uninit process issue Chenghai Huang
2024-04-03 10:00 ` [PATCH 3/9] crypto: hisilicon/sgl - Delete redundant parameter verification Chenghai Huang
2024-04-03 10:00 ` Chenghai Huang [this message]
2024-04-03 10:00 ` [PATCH 5/9] crypto: hisilicon/qm - Add the default processing branch Chenghai Huang
2024-04-03 10:00 ` [PATCH 6/9] crypto: hisilicon - Adjust debugfs creation and release order Chenghai Huang
2024-04-03 10:01 ` [PATCH 7/9] crypto: hisilicon/sec - Fix memory leak for sec resource release Chenghai Huang
2024-04-03 10:01 ` [PATCH 8/9] crypto: hisilicon/debugfs - Resolve the problem of applying for redundant space in sq dump Chenghai Huang
2024-04-03 22:57 ` kernel test robot
2024-04-03 10:01 ` [PATCH 9/9] crypto: hisilicon/debugfs - Add the err memory release process to qm uninit Chenghai Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240403100102.2735306-5-huangchenghai2@huawei.com \
--to=huangchenghai2@huawei.com \
--cc=davem@davemloft.net \
--cc=fanghao11@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linwenkai6@hisilicon.com \
--cc=liulongfang@huawei.com \
--cc=liushangbin@hisilicon.com \
--cc=qianweili@huawei.com \
--cc=shenyang39@huawei.com \
--cc=songzhiqi1@huawei.com \
--cc=taoqi10@huawei.com \
--cc=wangzhou1@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).