From: Josef Bacik <josef@toxicpanda.com>
To: linux-btrfs@vger.kernel.org, kernel-team@fb.com
Subject: [PATCH v2 00/15] btrfs: snapshot delete cleanups
Date: Mon, 29 Apr 2024 09:29:35 -0400 [thread overview]
Message-ID: <cover.1714397222.git.josef@toxicpanda.com> (raw)
v1->v2:
- Simply removed the btrfs_check_eb_owner() calls as per Qu's suggestion.
- Made the 0 reference count error be more verbose as per Dave's suggestion.
--- Original email ---
Hello,
In light of the recent fix for snapshot delete I looked around at the code to
see if it could be cleaned up. I still feel like this could be reworked to make
the two stages clearer, but this series brings a lot of cleanups and
re-factoring as well as comments and documentation that hopefully make this code
easier for others to work in. I've broken up the do_walk_down() function into
discreet peices that are better documented and describe their use. I've also
taken the opportunity to remove a bunch of BUG_ON()'s in this code. I've run
this through the CI a few times as I made a couple of errors, but it's passing
cleanly now. Thanks,
Josef
Josef Bacik (15):
btrfs: don't do find_extent_buffer in do_walk_down
btrfs: remove all extra btrfs_check_eb_owner() calls
btrfs: use btrfs_read_extent_buffer in do_walk_down
btrfs: push lookup_info into walk_control
btrfs: move the eb uptodate code into it's own helper
btrfs: remove need_account in do_walk_down
btrfs: unify logic to decide if we need to walk down into a node
btrfs: extract the reference dropping code into it's own helper
btrfs: don't BUG_ON ENOMEM in walk_down_proc
btrfs: handle errors from ref mods during UPDATE_BACKREF
btrfs: replace BUG_ON with ASSERT in walk_down_proc
btrfs: clean up our handling of refs == 0 in snapshot delete
btrfs: convert correctness BUG_ON()'s to ASSERT()'s in walk_up_proc
btrfs: handle errors from btrfs_dec_ref properly
btrfs: add documentation around snapshot delete
fs/btrfs/ctree.c | 7 +-
fs/btrfs/disk-io.c | 4 -
fs/btrfs/extent-tree.c | 514 +++++++++++++++++++++++++++--------------
3 files changed, 342 insertions(+), 183 deletions(-)
--
2.43.0
next reply other threads:[~2024-04-29 13:29 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 13:29 Josef Bacik [this message]
2024-04-29 13:29 ` [PATCH v2 01/15] btrfs: don't do find_extent_buffer in do_walk_down Josef Bacik
2024-04-29 13:29 ` [PATCH v2 02/15] btrfs: remove all extra btrfs_check_eb_owner() calls Josef Bacik
2024-04-29 13:29 ` [PATCH v2 03/15] btrfs: use btrfs_read_extent_buffer in do_walk_down Josef Bacik
2024-04-29 13:29 ` [PATCH v2 04/15] btrfs: push lookup_info into walk_control Josef Bacik
2024-04-29 13:29 ` [PATCH v2 05/15] btrfs: move the eb uptodate code into it's own helper Josef Bacik
2024-04-29 13:29 ` [PATCH v2 06/15] btrfs: remove need_account in do_walk_down Josef Bacik
2024-04-29 13:29 ` [PATCH v2 07/15] btrfs: unify logic to decide if we need to walk down into a node Josef Bacik
2024-04-29 13:29 ` [PATCH v2 08/15] btrfs: extract the reference dropping code into it's own helper Josef Bacik
2024-04-29 13:29 ` [PATCH v2 09/15] btrfs: don't BUG_ON ENOMEM in walk_down_proc Josef Bacik
2024-04-29 13:29 ` [PATCH v2 10/15] btrfs: handle errors from ref mods during UPDATE_BACKREF Josef Bacik
2024-04-29 13:29 ` [PATCH v2 11/15] btrfs: replace BUG_ON with ASSERT in walk_down_proc Josef Bacik
2024-04-29 13:29 ` [PATCH v2 12/15] btrfs: clean up our handling of refs == 0 in snapshot delete Josef Bacik
2024-04-30 20:43 ` David Sterba
2024-04-29 13:29 ` [PATCH v2 13/15] btrfs: convert correctness BUG_ON()'s to ASSERT()'s in walk_up_proc Josef Bacik
2024-04-29 13:29 ` [PATCH v2 14/15] btrfs: handle errors from btrfs_dec_ref properly Josef Bacik
2024-04-29 13:29 ` [PATCH v2 15/15] btrfs: add documentation around snapshot delete Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=cover.1714397222.git.josef@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).