From: David Sterba <dsterba@suse.cz>
To: Josef Bacik <josef@toxicpanda.com>
Cc: linux-btrfs@vger.kernel.org, kernel-team@fb.com,
dan.carpenter@linaro.org
Subject: Re: [PATCH v2 12/15] btrfs: clean up our handling of refs == 0 in snapshot delete
Date: Tue, 30 Apr 2024 22:43:59 +0200 [thread overview]
Message-ID: <20240430204359.GO2585@twin.jikos.cz> (raw)
In-Reply-To: <3a191c918331eab2e7c47a3453f1ec0b8f5b5afe.1714397223.git.josef@toxicpanda.com>
On Mon, Apr 29, 2024 at 09:29:47AM -0400, Josef Bacik wrote:
> @@ -5775,7 +5789,12 @@ static noinline int walk_up_proc(struct btrfs_trans_handle *trans,
> path->locks[level] = 0;
> return ret;
> }
> - BUG_ON(wc->refs[level] == 0);
> + if (unlikely(wc->refs[level] == 0)) {
This still lacks the tree unlock as reported by Dan Carpenter in
https://lore.kernel.org/all/96789032-42fb-41c0-b16c-561ac00ca7c3@moroto.mountain/
> + btrfs_err(fs_info,
> + "bytenr %llu has 0 references, expect > 0",
> + eb->start);
> + return -EUCLEAN;
> + }
> if (wc->refs[level] == 1) {
> btrfs_tree_unlock_rw(eb, path->locks[level]);
> path->locks[level] = 0;
next prev parent reply other threads:[~2024-04-30 20:51 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-29 13:29 [PATCH v2 00/15] btrfs: snapshot delete cleanups Josef Bacik
2024-04-29 13:29 ` [PATCH v2 01/15] btrfs: don't do find_extent_buffer in do_walk_down Josef Bacik
2024-04-29 13:29 ` [PATCH v2 02/15] btrfs: remove all extra btrfs_check_eb_owner() calls Josef Bacik
2024-04-29 13:29 ` [PATCH v2 03/15] btrfs: use btrfs_read_extent_buffer in do_walk_down Josef Bacik
2024-04-29 13:29 ` [PATCH v2 04/15] btrfs: push lookup_info into walk_control Josef Bacik
2024-04-29 13:29 ` [PATCH v2 05/15] btrfs: move the eb uptodate code into it's own helper Josef Bacik
2024-04-29 13:29 ` [PATCH v2 06/15] btrfs: remove need_account in do_walk_down Josef Bacik
2024-04-29 13:29 ` [PATCH v2 07/15] btrfs: unify logic to decide if we need to walk down into a node Josef Bacik
2024-04-29 13:29 ` [PATCH v2 08/15] btrfs: extract the reference dropping code into it's own helper Josef Bacik
2024-04-29 13:29 ` [PATCH v2 09/15] btrfs: don't BUG_ON ENOMEM in walk_down_proc Josef Bacik
2024-04-29 13:29 ` [PATCH v2 10/15] btrfs: handle errors from ref mods during UPDATE_BACKREF Josef Bacik
2024-04-29 13:29 ` [PATCH v2 11/15] btrfs: replace BUG_ON with ASSERT in walk_down_proc Josef Bacik
2024-04-29 13:29 ` [PATCH v2 12/15] btrfs: clean up our handling of refs == 0 in snapshot delete Josef Bacik
2024-04-30 20:43 ` David Sterba [this message]
2024-04-29 13:29 ` [PATCH v2 13/15] btrfs: convert correctness BUG_ON()'s to ASSERT()'s in walk_up_proc Josef Bacik
2024-04-29 13:29 ` [PATCH v2 14/15] btrfs: handle errors from btrfs_dec_ref properly Josef Bacik
2024-04-29 13:29 ` [PATCH v2 15/15] btrfs: add documentation around snapshot delete Josef Bacik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240430204359.GO2585@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=dan.carpenter@linaro.org \
--cc=josef@toxicpanda.com \
--cc=kernel-team@fb.com \
--cc=linux-btrfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).