From: Paul Menzel <pmenzel@molgen.mpg.de>
To: Kiran K <kiran.k@intel.com>
Cc: ravishankar.srivatsa@intel.com, chethan.tumkur.narayan@intel.com,
vijay.satija@intel.com, linux-bluetooth@vger.kernel.org
Subject: Re: [PATCH v1 1/3] Bluetooth: btintel_pcie: Print Firmware Sequencer information
Date: Thu, 16 May 2024 15:01:22 +0200 [thread overview]
Message-ID: <f42caf85-6a43-4d18-b14d-b5a3c55af0d3@molgen.mpg.de> (raw)
In-Reply-To: <20240516123938.891523-1-kiran.k@intel.com>
Dear Kiran,
Am 16.05.24 um 14:39 schrieb Kiran K:
> From: Kiran <kiran.k@intel.com>
Should this be Kiran K?
> Firmware sequencer (FSEQ) is a common code shared across Bluetooth
> and Wifi. Printing FSEQ will help to debug if there is any mismatch
So, make `btintel_print_fseq_info()` public, and call it in btintel_pci.
> between Bluetooth and Wifi FSEQ.
Please paste one example message.
> Signed-off-by: Kiran <kiran.k@intel.com>
> ---
> drivers/bluetooth/btintel.c | 3 ++-
> drivers/bluetooth/btintel.h | 5 +++++
> drivers/bluetooth/btintel_pcie.c | 2 ++
> 3 files changed, 9 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index 0c855c3ee1c1..2c434ff9c47c 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -2713,7 +2713,7 @@ void btintel_set_msft_opcode(struct hci_dev *hdev, u8 hw_variant)
> }
> EXPORT_SYMBOL_GPL(btintel_set_msft_opcode);
>
> -static void btintel_print_fseq_info(struct hci_dev *hdev)
> +void btintel_print_fseq_info(struct hci_dev *hdev)
> {
> struct sk_buff *skb;
> u8 *p;
> @@ -2825,6 +2825,7 @@ static void btintel_print_fseq_info(struct hci_dev *hdev)
>
> kfree_skb(skb);
> }
> +EXPORT_SYMBOL_GPL(btintel_print_fseq_info);
>
> static int btintel_setup_combined(struct hci_dev *hdev)
> {
> diff --git a/drivers/bluetooth/btintel.h b/drivers/bluetooth/btintel.h
> index b5fea735e260..796953547932 100644
> --- a/drivers/bluetooth/btintel.h
> +++ b/drivers/bluetooth/btintel.h
> @@ -244,6 +244,7 @@ int btintel_bootloader_setup_tlv(struct hci_dev *hdev,
> struct intel_version_tlv *ver);
> int btintel_shutdown_combined(struct hci_dev *hdev);
> void btintel_hw_error(struct hci_dev *hdev, u8 code);
> +void btintel_print_fseq_info(struct hci_dev *hdev);
> #else
>
> static inline int btintel_check_bdaddr(struct hci_dev *hdev)
> @@ -373,4 +374,8 @@ static inline int btintel_shutdown_combined(struct hci_dev *hdev)
> static inline void btintel_hw_error(struct hci_dev *hdev, u8 code)
> {
> }
> +
> +static void btintel_print_fseq_info(struct hci_dev *hdev)
> +{
> +}
> #endif
> diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
> index 5b6805d87fcf..8d282ee2322c 100644
> --- a/drivers/bluetooth/btintel_pcie.c
> +++ b/drivers/bluetooth/btintel_pcie.c
> @@ -1197,9 +1197,11 @@ static int btintel_pcie_setup(struct hci_dev *hdev)
> bt_dev_err(hdev, "Unsupported Intel hw variant (%u)",
> INTEL_HW_VARIANT(ver_tlv.cnvi_bt));
> err = -EINVAL;
> + goto exit_error;
> break;
> }
>
> + btintel_print_fseq_info(hdev);
> exit_error:
> kfree_skb(skb);
>
Kind regards,
Paul
next prev parent reply other threads:[~2024-05-16 13:01 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 12:39 [PATCH v1 1/3] Bluetooth: btintel_pcie: Print Firmware Sequencer information Kiran K
2024-05-16 12:39 ` [PATCH v1 2/3] Bluetooth: btintel_pcie: Fix irq leak Kiran K
2024-05-16 12:39 ` [PATCH v1 3/3] Bluetooth: btintel_pcie: Fix REVERSE_INULL issue reported by coverity Kiran K
2024-05-16 13:03 ` K, Kiran
2024-05-16 13:01 ` Paul Menzel [this message]
2024-05-16 13:35 ` [PATCH v1 1/3] Bluetooth: btintel_pcie: Print Firmware Sequencer information K, Kiran
2024-05-16 13:11 ` [v1,1/3] " bluez.test.bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=f42caf85-6a43-4d18-b14d-b5a3c55af0d3@molgen.mpg.de \
--to=pmenzel@molgen.mpg.de \
--cc=chethan.tumkur.narayan@intel.com \
--cc=kiran.k@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ravishankar.srivatsa@intel.com \
--cc=vijay.satija@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).