From: "K, Kiran" <kiran.k@intel.com>
To: "linux-bluetooth@vger.kernel.org" <linux-bluetooth@vger.kernel.org>
Cc: "Srivatsa, Ravishankar" <ravishankar.srivatsa@intel.com>,
"Tumkur Narayan, Chethan" <chethan.tumkur.narayan@intel.com>,
"Satija, Vijay" <vijay.satija@intel.com>
Subject: RE: [PATCH v1 3/3] Bluetooth: btintel_pcie: Fix REVERSE_INULL issue reported by coverity
Date: Thu, 16 May 2024 13:03:17 +0000 [thread overview]
Message-ID: <PH0PR11MB7585A340F55F0B7C1961B18BF5ED2@PH0PR11MB7585.namprd11.prod.outlook.com> (raw)
In-Reply-To: <20240516123938.891523-3-kiran.k@intel.com>
Please ignore v1 series. I have published v2 version with Fixes tag included.
Thanks,
Kiran
>-----Original Message-----
>From: K, Kiran <kiran.k@intel.com>
>Sent: Thursday, May 16, 2024 6:10 PM
>To: linux-bluetooth@vger.kernel.org
>Cc: Srivatsa, Ravishankar <ravishankar.srivatsa@intel.com>; Tumkur Narayan,
>Chethan <chethan.tumkur.narayan@intel.com>; Satija, Vijay
><vijay.satija@intel.com>; K, Kiran <kiran.k@intel.com>
>Subject: [PATCH v1 3/3] Bluetooth: btintel_pcie: Fix REVERSE_INULL issue
>reported by coverity
>
>From: Vijay Satija <vijay.satija@intel.com>
>
>check pdata return of skb_pull_data, instead of data.
>
>Signed-off-by: Vijay Satija <vijay.satija@intel.com>
>Signed-off-by: Kiran K <kiran.k@intel.com>
>---
> drivers/bluetooth/btintel_pcie.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/bluetooth/btintel_pcie.c b/drivers/bluetooth/btintel_pcie.c
>index d8f82e0f6435..58144c82b1cb 100644
>--- a/drivers/bluetooth/btintel_pcie.c
>+++ b/drivers/bluetooth/btintel_pcie.c
>@@ -382,7 +382,7 @@ static int btintel_pcie_recv_frame(struct
>btintel_pcie_data *data,
>
> /* The first 4 bytes indicates the Intel PCIe specific packet type */
> pdata = skb_pull_data(skb, BTINTEL_PCIE_HCI_TYPE_LEN);
>- if (!data) {
>+ if (!pdata) {
> bt_dev_err(hdev, "Corrupted packet received");
> ret = -EILSEQ;
> goto exit_error;
>--
>2.40.1
next prev parent reply other threads:[~2024-05-16 13:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-16 12:39 [PATCH v1 1/3] Bluetooth: btintel_pcie: Print Firmware Sequencer information Kiran K
2024-05-16 12:39 ` [PATCH v1 2/3] Bluetooth: btintel_pcie: Fix irq leak Kiran K
2024-05-16 12:39 ` [PATCH v1 3/3] Bluetooth: btintel_pcie: Fix REVERSE_INULL issue reported by coverity Kiran K
2024-05-16 13:03 ` K, Kiran [this message]
2024-05-16 13:01 ` [PATCH v1 1/3] Bluetooth: btintel_pcie: Print Firmware Sequencer information Paul Menzel
2024-05-16 13:35 ` K, Kiran
2024-05-16 13:11 ` [v1,1/3] " bluez.test.bot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=PH0PR11MB7585A340F55F0B7C1961B18BF5ED2@PH0PR11MB7585.namprd11.prod.outlook.com \
--to=kiran.k@intel.com \
--cc=chethan.tumkur.narayan@intel.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=ravishankar.srivatsa@intel.com \
--cc=vijay.satija@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).