From: Tengfei Fan <quic_tengfan@quicinc.com>
To: Krzysztof Kozlowski <krzk@kernel.org>, <andersson@kernel.org>,
<konrad.dybcio@linaro.org>, <robh@kernel.org>,
<krzk+dt@kernel.org>, <conor+dt@kernel.org>
Cc: <linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, <kernel@quicinc.com>
Subject: Re: [PATCH] arm64: dts: qcom: sm8550: Move some common usb node settings to SoC dtsi
Date: Tue, 14 May 2024 08:52:59 +0800 [thread overview]
Message-ID: <66e5bf06-6302-47f3-9bdd-5213a1e6c570@quicinc.com> (raw)
In-Reply-To: <829162d0-2fef-4bbc-9417-13e8ca96150c@kernel.org>
On 5/13/2024 4:56 PM, Krzysztof Kozlowski wrote:
> On 13/05/2024 10:47, Tengfei Fan wrote:
>> All the board dts which base on SM8550 SoC dtsi refer to usb_1_dwc3_ss,
>> usb_dp_qmpphy_usb_ss_in, orientation-switch and usb-role-switch, so move
>> them to SoC dtsi from board dts.
>
> That's not really a good argument. Argument is that it is a SoC property
> (vs being a property of a board). Provide rationale for that. You are
> moving things just because they look common, so to me it looks really
> unjustified.
In the next version of the patch series, I will modify the commit
message to more accurately indicate why they need to be moved SoC dtsi.
>
>> OTG is default for dr_mode, so it can be dropped from board dts.
>
> Separate patch, see submitting patches.
In the next version of the patch series, I will separate this.
>
> Best regards,
> Krzysztof
>
--
Thx and BRs,
Tengfei Fan
prev parent reply other threads:[~2024-05-14 0:53 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-13 8:47 [PATCH] arm64: dts: qcom: sm8550: Move some common usb node settings to SoC dtsi Tengfei Fan
2024-05-13 8:56 ` Krzysztof Kozlowski
2024-05-14 0:52 ` Tengfei Fan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=66e5bf06-6302-47f3-9bdd-5213a1e6c570@quicinc.com \
--to=quic_tengfan@quicinc.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=kernel@quicinc.com \
--cc=konrad.dybcio@linaro.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).