From: James Prestwood <prestwoj@gmail.com>
To: iwd@lists.linux.dev
Cc: James Prestwood <prestwoj@gmail.com>
Subject: [RFC 0/5] Initial refactor for hwsim frame processing
Date: Fri, 30 Jun 2023 12:18:07 -0700 [thread overview]
Message-ID: <20230630191812.2884637-1-prestwoj@gmail.com> (raw)
I wanted to put this out there just as an idea before I get too
invested in extending it. The code itself needs cleanup (explained
later) but I wanted some feedback on the general idea.
Eventually I'd like to extend this to support remote communication
with multiple hwsim instances, e.g. via a multicast socket. As a
starting point the rules code fit nicely as a frame processing
module.
Cleanup:
- Find solution for the IWD_MODULE_DEPENDS issue
- Add getters for radio/interface info objects, possibly
for hwsim_frame too rather than everything exposed in
hwsim.h.
- The hwsim_frame cleanup in rules needs to be changed. Prior
hwsim_frame_unref() would send tx_info but now this needs
to be handled in rules.c. Currently we peek into the refcount
and see if it will be destroyed on unref, and send tx_info
then.
The dbus dependency patches by themselves are actually useful so
feel free to merge those if they look ok. If you don't like the
preprocessor define thats fine, its a minimal amount of code
duplicated between iwd/hwsim so its not _that_ bad as it stands
today.
Note: These were done on top of the ADD/DEL mac changes so if
they don't apply that is likely the issue. Again, just looking
for a yay or nay on this concept.
James Prestwood (5):
dbus: remove dependency on agent
dbus: remove iwd.h dependency
hwsim: use dbus.c module
hwsim: refactor rules processing into separate file
module: temporary hack to allow for no module dependencies
Makefile.am | 9 +-
src/agent.c | 12 +-
src/agent.h | 2 -
src/dbus.c | 43 +-
src/dbus.h | 4 +
src/module.c | 6 +
tools/hwsim.c | 1115 +++----------------------------------------------
tools/hwsim.h | 99 +++++
tools/rules.c | 1017 ++++++++++++++++++++++++++++++++++++++++++++
9 files changed, 1224 insertions(+), 1083 deletions(-)
create mode 100644 tools/hwsim.h
create mode 100644 tools/rules.c
--
2.25.1
next reply other threads:[~2023-06-30 19:18 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 19:18 James Prestwood [this message]
2023-06-30 19:18 ` [RFC 1/5] dbus: remove dependency on agent James Prestwood
2023-06-30 19:18 ` [RFC 2/5] dbus: remove iwd.h dependency James Prestwood
2023-07-06 3:17 ` Denis Kenzior
2023-07-10 16:58 ` James Prestwood
2023-06-30 19:18 ` [RFC 3/5] hwsim: use dbus.c module James Prestwood
2023-06-30 19:18 ` [RFC 4/5] hwsim: refactor rules processing into separate file James Prestwood
2023-06-30 19:18 ` [RFC 5/5] module: temporary hack to allow for no module dependencies James Prestwood
2023-07-06 4:36 ` [RFC 0/5] Initial refactor for hwsim frame processing Denis Kenzior
2023-07-10 17:13 ` James Prestwood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230630191812.2884637-1-prestwoj@gmail.com \
--to=prestwoj@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).