From: James Prestwood <prestwoj@gmail.com>
To: Denis Kenzior <denkenz@gmail.com>, iwd@lists.linux.dev
Subject: Re: [RFC 0/5] Initial refactor for hwsim frame processing
Date: Mon, 10 Jul 2023 10:13:36 -0700 [thread overview]
Message-ID: <1a248b20-c31d-d948-48ab-4221c416a0bf@gmail.com> (raw)
In-Reply-To: <12fbf71d-976d-fe2a-7326-547dab44b84a@gmail.com>
Hi Denis,
On 7/5/23 9:36 PM, Denis Kenzior wrote:
> Hi James,
>
> On 6/30/23 14:18, James Prestwood wrote:
>> I wanted to put this out there just as an idea before I get too
>> invested in extending it. The code itself needs cleanup (explained
>> later) but I wanted some feedback on the general idea.
>
> No real objection, but if you're moving 1kloc of code around, make sure
> that any moves are separated from overall refinements and other
> changes. For example, if you're exporting API functions or structures
> for use in (newly created) modules, do that first.
Yep definitely.
>
>>
>> Eventually I'd like to extend this to support remote communication
>> with multiple hwsim instances, e.g. via a multicast socket. As a
>> starting point the rules code fit nicely as a frame processing
>> module.
>
> I assume you saw https://github.com/Raizo62/vwifi ?
I had not seen that one, but its pretty close to what I'm looking for.
Still would need some specific modifications but its at least being
maintained somewhat. Definitely worth looking into.
There is also a similar project, but its old and doesn't look
particularly finished:
https://github.com/cmu-sei/welled
>
>>
>> Cleanup:
>> - Find solution for the IWD_MODULE_DEPENDS issue
>
> Well, you need to put something into the section if you don't invoke
> IWD_MODULE_DEPENDS at least once.
>
>> - Add getters for radio/interface info objects, possibly
>> for hwsim_frame too rather than everything exposed in
>> hwsim.h.
>
> That would be preferable.
>
>> - The hwsim_frame cleanup in rules needs to be changed. Prior
>> hwsim_frame_unref() would send tx_info but now this needs
>> to be handled in rules.c. Currently we peek into the refcount
>> and see if it will be destroyed on unref, and send tx_info
>> then.
>
> Hmm, not sure I follow yet?
Just minor details really, I need to just look at it closer once its in
a more finished state.
>
> Also, iwd/tools/* is for executables that get built from single files.
> I guess we could relax that, but it may be better to have hwsim live in
> its own directory, similar to ead & iwmon.
Ok that does make more sense.
>
> Regards,
> -Denis
prev parent reply other threads:[~2023-07-10 17:13 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-30 19:18 [RFC 0/5] Initial refactor for hwsim frame processing James Prestwood
2023-06-30 19:18 ` [RFC 1/5] dbus: remove dependency on agent James Prestwood
2023-06-30 19:18 ` [RFC 2/5] dbus: remove iwd.h dependency James Prestwood
2023-07-06 3:17 ` Denis Kenzior
2023-07-10 16:58 ` James Prestwood
2023-06-30 19:18 ` [RFC 3/5] hwsim: use dbus.c module James Prestwood
2023-06-30 19:18 ` [RFC 4/5] hwsim: refactor rules processing into separate file James Prestwood
2023-06-30 19:18 ` [RFC 5/5] module: temporary hack to allow for no module dependencies James Prestwood
2023-07-06 4:36 ` [RFC 0/5] Initial refactor for hwsim frame processing Denis Kenzior
2023-07-10 17:13 ` James Prestwood [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1a248b20-c31d-d948-48ab-4221c416a0bf@gmail.com \
--to=prestwoj@gmail.com \
--cc=denkenz@gmail.com \
--cc=iwd@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).