Intel-GFX Archive mirror
 help / color / mirror / Atom feed
From: "Hogander, Jouni" <jouni.hogander@intel.com>
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>
Cc: "dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"maarten.lankhorst@linux.intel.com"
	<maarten.lankhorst@linux.intel.com>,
	"Manna, Animesh" <animesh.manna@intel.com>,
	"mripard@kernel.org" <mripard@kernel.org>,
	"tzimmermann@suse.de" <tzimmermann@suse.de>
Subject: Re: [PATCH v10 00/12] Panel replay selective update support
Date: Wed, 15 May 2024 08:29:54 +0000	[thread overview]
Message-ID: <1e97cd6a6b1f695c0609d1ac2b7a0ee38acb41f7.camel@intel.com> (raw)
In-Reply-To: <20240510093823.3146455-1-jouni.hogander@intel.com>

On Fri, 2024-05-10 at 12:38 +0300, Jouni Högander wrote:
> This patch set is implementing panel replay selective update support
> for Intel hardware.

These are now merged into drm-intel-next including "drm/panelreplay:
dpcd register definition for panelreplay SU".

Thank you Animesh and Maarten for review and ack.

BR,

Jouni Högander

> 
> v10:
>   - use always PSR2_STATUS for eDP Panel Replay
>   - handle SRD_STATUS vs. PSR2_STATUS in intel_psr_wait_exit_locked
> as well
> v9:
>   - do not add has_psr check into psr2 case in
> intel_dp_compute_vsc_sdp
>   - use drm_dp_dpcd_readb instead of drm_dp_dpcd_read in
> intel_dp_get_su_capability
>   - ensure intel_dp_get_su_capability returns 0 if drm_dp_dpcd_readb
> fails
> v8:
>   - use correct offset for DP_PANEL_PANEL_REPLAY_CAPABILITY
> v7:
>   - use always vsc revision 0x6 for Panel Replay
> v6:
>   - fixes split to separate patch set
> v5:
>   - do not use PSR2_STATUS for PSR1
> v4:
>   - do not rename intel_psr_enabled
>   - do not add sel_update_et_enabled into struct intel_psr
> v3:
>   - do not disable panel replay by default
>   - set has_psr for panel replay as well
>   - enable sink before link training
>   - do not apply all PSR workarounds for panel replay
>   - do not write/read registers/bits not applicable for panel replay
>   - use psr bit definitions in granularity configuration as well
>   - goto unsupported instead of return when global enabled check
> fails
>   - update module parameter descriptions.
> v2:
>   - make psr pause/resume to work for panel replay as well
> 
> Jouni Högander (12):
>   drm/i915/psr: Rename has_psr2 as has_sel_update
>   drm/i915/display: Do not print "psr: enabled" for on Panel Replay
>   drm/i915/dp: Use always vsc revision 0x6 for Panel Replay
>   drm/i915/psr: Rename psr2_enabled as sel_update_enabled
>   drm/panelreplay: dpcd register definition for panelreplay SU
>   drm/i915/psr: Detect panel replay selective update support
>   drm/i915/psr: Modify intel_dp_get_su_granularity to support panel
>     replay
>   drm/i915/psr: Panel replay uses SRD_STATUS to track it's status
>   drm/i915/psr: Do not apply workarounds in case of panel replay
>   drm/i915/psr: Update PSR module parameter descriptions
>   drm/i915/psr: Split intel_psr2_config_valid for panel replay
>   drm/i915/psr: Add panel replay sel update support to debugfs
> interface
> 
>  .../drm/i915/display/intel_crtc_state_dump.c  |   7 +-
>  drivers/gpu/drm/i915/display/intel_display.c  |   2 +-
>  .../drm/i915/display/intel_display_params.c   |   5 +-
>  .../drm/i915/display/intel_display_types.h    |   5 +-
>  drivers/gpu/drm/i915/display/intel_dp.c       |  17 +-
>  drivers/gpu/drm/i915/display/intel_fbc.c      |   5 +-
>  drivers/gpu/drm/i915/display/intel_hdmi.c     |   3 +-
>  drivers/gpu/drm/i915/display/intel_psr.c      | 237 ++++++++++++----
> --
>  include/drm/display/drm_dp.h                  |   6 +
>  9 files changed, 194 insertions(+), 93 deletions(-)
> 


      parent reply	other threads:[~2024-05-15  8:30 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-05-10  9:38 [PATCH v10 00/12] Panel replay selective update support Jouni Högander
2024-05-10  9:38 ` [PATCH v10 01/12] drm/i915/psr: Rename has_psr2 as has_sel_update Jouni Högander
2024-05-10  9:38 ` [PATCH v10 02/12] drm/i915/display: Do not print "psr: enabled" for on Panel Replay Jouni Högander
2024-05-10  9:38 ` [PATCH v10 03/12] drm/i915/dp: Use always vsc revision 0x6 for " Jouni Högander
2024-05-10  9:38 ` [PATCH v10 04/12] drm/i915/psr: Rename psr2_enabled as sel_update_enabled Jouni Högander
2024-05-10  9:38 ` [PATCH v10 05/12] drm/panelreplay: dpcd register definition for panelreplay SU Jouni Högander
2024-05-10  9:45   ` Jani Nikula
2024-05-10 10:27     ` Hogander, Jouni
2024-05-10  9:38 ` [PATCH v10 06/12] drm/i915/psr: Detect panel replay selective update support Jouni Högander
2024-05-10  9:38 ` [PATCH v10 07/12] drm/i915/psr: Modify intel_dp_get_su_granularity to support panel replay Jouni Högander
2024-05-10  9:38 ` [PATCH v10 08/12] drm/i915/psr: Panel replay uses SRD_STATUS to track it's status Jouni Högander
2024-05-10 10:59   ` Manna, Animesh
2024-05-10  9:38 ` [PATCH v10 09/12] drm/i915/psr: Do not apply workarounds in case of panel replay Jouni Högander
2024-05-10  9:38 ` [PATCH v10 10/12] drm/i915/psr: Update PSR module parameter descriptions Jouni Högander
2024-05-10  9:38 ` [PATCH v10 11/12] drm/i915/psr: Split intel_psr2_config_valid for panel replay Jouni Högander
2024-05-10  9:38 ` [PATCH v10 12/12] drm/i915/psr: Add panel replay sel update support to debugfs interface Jouni Högander
2024-05-10 11:35 ` ✗ Fi.CI.CHECKPATCH: warning for Panel replay selective update support (rev11) Patchwork
2024-05-10 11:35 ` ✗ Fi.CI.SPARSE: " Patchwork
2024-05-10 11:42 ` ✓ Fi.CI.BAT: success " Patchwork
2024-05-11  2:00 ` ✗ Fi.CI.IGT: failure " Patchwork
2024-05-13  5:17   ` Hogander, Jouni
2024-05-15  8:29 ` Hogander, Jouni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1e97cd6a6b1f695c0609d1ac2b7a0ee38acb41f7.camel@intel.com \
    --to=jouni.hogander@intel.com \
    --cc=animesh.manna@intel.com \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=tzimmermann@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).