From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Dragan Simic <dsimic@manjaro.org>,
prpr 19xx <prpr19xx@gmail.com>,
git@vger.kernel.org
Subject: Re: Warning message in remote.c when compiling
Date: Sat, 06 Apr 2024 22:40:25 -0700 [thread overview]
Message-ID: <xmqqzfu5hgs6.fsf@gitster.g> (raw)
In-Reply-To: <20240407013843.GE1085004@coredump.intra.peff.net> (Jeff King's message of "Sat, 6 Apr 2024 21:38:43 -0400")
Jeff King <peff@peff.net> writes:
> I don't really see any need to mark the wrapper as inline. It's one
> basic function call (on top of an interface which requires a callback
> anyway!), and I suspect many compilers would consider inlining anyway,
> since it's a static function.
>
> Ditto for remotes_pushremote_get(), though it doesn't have a forward
> declaration.
Yup. I presonally feel that we should get rid of "static inline"
unless they appear in header files. The compilers should in general
be able to do good enough job finding what to inline than we can (1)
initially mark what to inline, and (2) update by dropping "inline"
that is no longer appropriate as the code evolves.
Thanks.
next prev parent reply other threads:[~2024-04-07 5:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 14:21 Warning message in remote.c when compiling prpr 19xx
2024-04-06 16:12 ` Dragan Simic
2024-04-07 1:38 ` Jeff King
2024-04-07 5:10 ` Dragan Simic
2024-04-07 5:40 ` Junio C Hamano [this message]
2024-04-07 16:47 ` prpr 19xx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqzfu5hgs6.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=prpr19xx@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).