From: prpr 19xx <prpr19xx@gmail.com>
To: git@vger.kernel.org
Subject: Warning message in remote.c when compiling
Date: Sat, 6 Apr 2024 15:21:55 +0100 [thread overview]
Message-ID: <CAA1Aqdvj6Eyp9jGaAxTf8p0Eh_rCPydOpin3D5QYHy8sqOoOsw@mail.gmail.com> (raw)
Hi,
I get this warning message when compiling remote.c:
...
CC remote.o
remote.c:596: warning: 'remotes_remote_get' declared inline after being called
remote.c:596: warning: previous declaration of 'remotes_remote_get' was here
CC replace-object.o
...
This is from the "master" branch, but it's the same on "next". It's
easily fixed with this patch:
diff --git a/remote.c b/remote.c
index 2b650b8..347f504 100644
--- a/remote.c
+++ b/remote.c
@@ -592,7 +592,7 @@ const char *pushremote_for_branch(struct branch
*branch, int *explicit)
branch, explicit);
}
-static struct remote *remotes_remote_get(struct remote_state *remote_state,
+static inline struct remote *remotes_remote_get(struct remote_state
*remote_state,
const char *name);
const char *remote_ref_for_branch(struct branch *branch, int for_push)
Thanks.
next reply other threads:[~2024-04-06 14:22 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-06 14:21 prpr 19xx [this message]
2024-04-06 16:12 ` Warning message in remote.c when compiling Dragan Simic
2024-04-07 1:38 ` Jeff King
2024-04-07 5:10 ` Dragan Simic
2024-04-07 5:40 ` Junio C Hamano
2024-04-07 16:47 ` prpr 19xx
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAA1Aqdvj6Eyp9jGaAxTf8p0Eh_rCPydOpin3D5QYHy8sqOoOsw@mail.gmail.com \
--to=prpr19xx@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).