From: Junio C Hamano <gitster@pobox.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: "skrab-sah via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>,
skrab-sah <skrab.sah@gmail.com>
Subject: Re: [PATCH v2] abspath.h file is generated by makeheaders tool
Date: Sun, 16 Oct 2022 09:51:56 -0700 [thread overview]
Message-ID: <xmqqsfjn4spf.fsf@gitster.g> (raw)
In-Reply-To: <Y0wDieA32uVtYmgx@danh.dev> ("Đoàn Trần Công Danh"'s message of "Sun, 16 Oct 2022 20:13:45 +0700")
Đoàn Trần Công Danh <congdanhqx@gmail.com> writes:
> This will break cross-compilation.
> At the very least, we needs to use either HOSTCC (likes linux project),
> HOST_CC or CC_FOR_BUILD (GNU Autotools' convention) to compile
> makeheaders
>
> So, something like (not tested, whatsoever):
I find it a bit irresponsible to leave the suggestion sounding as if
this is a good idea as long as it does not break cross-compilation,
which will (mis)lead the original poster to waste even more time on
this topic (and waste others' time on responding to it), so let me
repeat what I already said a few times.
Whether the headers mechanically generated gets committed or not,
this line of change is unwelcome. Developers should be able to look
at the header files (and interface document, if we ever generate one
out of structured comments in the header files) when using common
functions that they are not (yet) familiar with, and we want to see
our header files manually curated.
Thanks.
next prev parent reply other threads:[~2022-10-16 16:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 8:36 [PATCH] abspath.h file is generated by makeheaders tool skrab-sah via GitGitGadget
2022-10-12 9:04 ` Ævar Arnfjörð Bjarmason
2022-10-13 16:40 ` [PATCH v2] " skrab-sah via GitGitGadget
2022-10-16 9:44 ` Skrab Sah
2022-10-16 13:13 ` Đoàn Trần Công Danh
2022-10-16 16:06 ` Skrab Sah
2022-10-16 16:51 ` Junio C Hamano [this message]
2022-10-17 0:34 ` Đoàn Trần Công Danh
2022-10-17 7:55 ` Skrab Sah
2022-10-17 18:39 ` Junio C Hamano
2022-10-18 0:52 ` Skrab Sah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqsfjn4spf.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=avarab@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=skrab.sah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).