From: Skrab Sah <skrab.sah@gmail.com>
To: "Đoàn Trần Công Danh" <congdanhqx@gmail.com>
Cc: "Junio C Hamano" <gitster@pobox.com>,
"skrab-sah via GitGitGadget" <gitgitgadget@gmail.com>,
git@vger.kernel.org, "Ævar Arnfjörð Bjarmason" <avarab@gmail.com>
Subject: Re: [PATCH v2] abspath.h file is generated by makeheaders tool
Date: Mon, 17 Oct 2022 13:25:46 +0530 [thread overview]
Message-ID: <CA+J78MV1yYVA0ijRPMPVAbGWML5SaL70yKASmHY2HWnuk1jVkA@mail.gmail.com> (raw)
In-Reply-To: <Y0yiRUzHbBvpT2I1@danh.dev>
> I find it a bit irresponsible to leave the suggestion sounding as if
> this is a good idea as long as it does not break cross-compilation,
> which will (mis)lead the original poster to waste even more time on
> this topic (and waste others' time on responding to it).
No. no. it's not for the previous replay i am asking for.
Back in the days, I was asked by Ævar Arnfjörð Bjarmason.
" * It's unclear if you mean that we'd commit the generated files or
not. If "not" then our Makefile will need to learn to do two-stage
compilation. I.e. we'd ship a copy of the makeheader tool, build
that, build the headers, and then do our "real" build."
My answer was.
"There are different ways we can install the makeheaders tool."
As the related question asked, I remembered it. so, I asked as this
will solve the cross-compilation problem also, if it is good.
> so let me repeat what I already said a few times.
>
> Whether the headers mechanically generated gets committed or not,
> this line of change is unwelcome. Developers should be able to look
> at the header files (and interface document, if we ever generate one
> out of structured comments in the header files) when using common
> functions that they are not (yet) familiar with, and we want to see
> our header files manually curated.
You repeated the question for me so, really sorry.
I know you have already told me that, and it is important also as
generally people try to find documentation for function in the header
file. It is also not good when sharing libraries and its related
header files without documentation.
I tried to find the solution.
By reading the manual and By viewing the source code, I found it
doesn't support it.
So, I am going to either modify it or create a new one.
And also I have remembered all your points, I will try to implement it.
> I'm sorry.
>
> I thought my earlier voice to not support this proposal was't
> necessary to be re-iterated. I only think that if this proposal
> somehow got accepted (despite I don't like this proposal), something
> needs to be fixed.
>
> I will be explicit next time.
No. no. you don't need to be sorry.
I know this proposal is not going to be accepted now.
Too many things have to be done here and I am working on it.
My question was.
1. Until now, are there any problems which need to be solved.
2. Why it gives errors in CI / win test (8) (pull_request) test. (Important)
next prev parent reply other threads:[~2022-10-17 7:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-12 8:36 [PATCH] abspath.h file is generated by makeheaders tool skrab-sah via GitGitGadget
2022-10-12 9:04 ` Ævar Arnfjörð Bjarmason
2022-10-13 16:40 ` [PATCH v2] " skrab-sah via GitGitGadget
2022-10-16 9:44 ` Skrab Sah
2022-10-16 13:13 ` Đoàn Trần Công Danh
2022-10-16 16:06 ` Skrab Sah
2022-10-16 16:51 ` Junio C Hamano
2022-10-17 0:34 ` Đoàn Trần Công Danh
2022-10-17 7:55 ` Skrab Sah [this message]
2022-10-17 18:39 ` Junio C Hamano
2022-10-18 0:52 ` Skrab Sah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CA+J78MV1yYVA0ijRPMPVAbGWML5SaL70yKASmHY2HWnuk1jVkA@mail.gmail.com \
--to=skrab.sah@gmail.com \
--cc=avarab@gmail.com \
--cc=congdanhqx@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).