From: Junio C Hamano <gitster@pobox.com>
To: Patrick Steinhardt <ps@pks.im>
Cc: git@vger.kernel.org
Subject: Re: ps/fetch-output-format
Date: Fri, 12 May 2023 12:33:25 -0700 [thread overview]
Message-ID: <xmqqmt29pcoq.fsf@gitster.g> (raw)
In-Reply-To: <ZF3nFaHjOxt4a3ee@ncase> (Patrick Steinhardt's message of "Fri, 12 May 2023 09:13:25 +0200")
Patrick Steinhardt <ps@pks.im> writes:
> We may add below diff to "fetch: introduce `display_format` enum". No
> further changes would be required for any of the other patches as we
> always explicitly initialize the value already and don't use the
> `UNKNOWN` value anywhere.
Yup, if I were writing this series from scratch I wouldn't have
added the UNKNOWN one myself, but it is so small thing that we can
leave it for those who want to do trivial clean-ups after the dust
settles (it could even be one of future microprojects).
>
> diff --git a/builtin/fetch.c b/builtin/fetch.c
> index 462fc86b99..6583e31e3d 100644
> --- a/builtin/fetch.c
> +++ b/builtin/fetch.c
> @@ -49,7 +49,6 @@ enum {
> };
>
> enum display_format {
> - DISPLAY_FORMAT_UNKNOWN = 0,
> DISPLAY_FORMAT_FULL,
> DISPLAY_FORMAT_COMPACT,
> DISPLAY_FORMAT_PORCELAIN,
>
> I'm rather indifferent though and feel like re-sending all patches only
> to change this one line of code generates too much noise. But I'm happy
> to adjust in order to make your life easier.
>
> Thanks!
>
> Patrick
next prev parent reply other threads:[~2023-05-12 19:33 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 0:39 What's cooking in git.git (May 2023, #04; Thu, 11) Junio C Hamano
2023-05-12 1:36 ` Felipe Contreras
2023-05-12 3:05 ` Taylor Blau
2023-05-12 3:46 ` Felipe Contreras
2023-05-12 7:13 ` ps/fetch-output-format (was: What's cooking in git.git (May 2023, #04; Thu, 11)) Patrick Steinhardt
2023-05-12 19:33 ` Junio C Hamano [this message]
2023-05-12 15:26 ` tl/push-branches-is-an-alias-for-all (Was: " Elijah Newren
2023-05-12 17:23 ` tl/push-branches-is-an-alias-for-all Junio C Hamano
2023-05-12 20:52 ` What's cooking in git.git (May 2023, #04; Thu, 11) brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqqmt29pcoq.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ps@pks.im \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).