From: Junio C Hamano <gitster@pobox.com>
To: Elijah Newren <newren@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>, Teng Long <dyroneteng@gmail.com>
Subject: Re: tl/push-branches-is-an-alias-for-all
Date: Fri, 12 May 2023 10:23:06 -0700 [thread overview]
Message-ID: <xmqq3541qxad.fsf@gitster.g> (raw)
In-Reply-To: <CABPp-BFLOpsm6wg+CidEHaQhJ4FTnszfj8SUeBWxkFZgSeJ8Nw@mail.gmail.com> (Elijah Newren's message of "Fri, 12 May 2023 08:26:09 -0700")
Elijah Newren <newren@gmail.com> writes:
> On Thu, May 11, 2023 at 6:22 PM Junio C Hamano <gitster@pobox.com> wrote:
>>
>> * tl/push-branches-is-an-alias-for-all (2023-05-06) 1 commit
>> (merged to 'next' on 2023-05-09 at 1d8c3e5dcf)
>> + push: introduce '--branches' option
>>
>> "git push --all" gained an alias "git push --branches".
>>
>> Will merge to 'master'.
>> source: <20230506113408.61529-2-tenglong.tl@alibaba-inc.com>
>
> This topic breaks the tests for me; it needs a trivial one-character
> fix: https://lore.kernel.org/git/pull.1532.git.1683904156670.gitgitgadget@gmail.com/
I wonder what made this breakage hidden. I usually run the tests
after accepting a series standalone, and I run the full test suite
(excluding the ones that depend on things I do not have, like p4)
with bash and dash before pushing anything out, and I haven't seen
GitHub Actions break due to this.
Ah, it is because t/Makefile essentially uses $(TEST_SHELL_PATH_SQ)
to run $@, instead of directly doing "./$@", in both cases with and
without probe. This is very much deliberate in that we do not want
to rely on and get affected by whichever shell choice the system
administrator made when installing "/bin/sh".
I'll apply your patch primarily for consistency (a shell script file
that begins with "#!bin/sh" never is a good thing, and everybody
else begins with "#!/bin/sh") for now, but I think the justification
of your patch is questionable in that we do not want our developers
to rely on "./t5583-push-branches.sh" to work [*], as these scripts
are designed to run under $(TEST_SHELL_PATH).
Thanks.
[Footnote]
* We could, for example, make t/t[0-9][0-9][0-9]-*.sh scripts
consistently use bogus shebang line to catch possible breakage to
t/Makefile that bypasses $(TEST_SHELL_PATH) in the future. If
that happens, developers who expect ./t5583-push-branches.sh to
work will be broken.
next prev parent reply other threads:[~2023-05-12 17:23 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-12 0:39 What's cooking in git.git (May 2023, #04; Thu, 11) Junio C Hamano
2023-05-12 1:36 ` Felipe Contreras
2023-05-12 3:05 ` Taylor Blau
2023-05-12 3:46 ` Felipe Contreras
2023-05-12 7:13 ` ps/fetch-output-format (was: What's cooking in git.git (May 2023, #04; Thu, 11)) Patrick Steinhardt
2023-05-12 19:33 ` ps/fetch-output-format Junio C Hamano
2023-05-12 15:26 ` tl/push-branches-is-an-alias-for-all (Was: Re: What's cooking in git.git (May 2023, #04; Thu, 11)) Elijah Newren
2023-05-12 17:23 ` Junio C Hamano [this message]
2023-05-12 20:52 ` What's cooking in git.git (May 2023, #04; Thu, 11) brian m. carlson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=xmqq3541qxad.fsf@gitster.g \
--to=gitster@pobox.com \
--cc=dyroneteng@gmail.com \
--cc=git@vger.kernel.org \
--cc=newren@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).