From: Dragan Simic <dsimic@manjaro.org>
To: Eric Sunshine <sunshine@sunshineco.com>
Cc: git@vger.kernel.org, gitster@pobox.com, jn.avila@free.fr
Subject: Re: [PATCH v3 0/3] Assorted improvements salvaged from an earlier series
Date: Mon, 25 Mar 2024 21:54:18 +0100 [thread overview]
Message-ID: <a3bc4829036f5803da513fee52267c2c@manjaro.org> (raw)
In-Reply-To: <CAPig+cRECapN-9_u0JoESaS7KTi-==ri7Oy+sjff-VHL7p+vHQ@mail.gmail.com>
On 2024-03-25 21:49, Eric Sunshine wrote:
> On Mon, Mar 25, 2024 at 4:41 PM Dragan Simic <dsimic@manjaro.org>
> wrote:
>> On 2024-03-25 21:39, Eric Sunshine wrote:
>> > Prose description of the changes between versions is very much welcome
>> > by reviewers, but please also include a range-diff[1] or interdiff[2]
>> > when preparing a reroll.
>>
>> Ah, sorry, I didn't forget about that, but I just intended to start
>> providing range-diffs for future patches. These were more like new
>> versions of old patches.
>
> The range-diff is particularly valuable exactly for this case (new
> versions of old patches) since it is a "diff" between the old patches
> and the new patches. Thus, it provides reviewers with a precise
> summary of what changed between, say, v2 and v3 of a series, and
> manifests as a concrete representation of what your prose explanation
> describes.
I see, and I do understand the purpose of range-diffs: they make
reviewing new patch versions significantly easier, by relieving the
reviewers from the need to track down what has been changed in the
current patch version.
next prev parent reply other threads:[~2024-03-25 20:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 20:34 [PATCH v3 0/3] Assorted improvements salvaged from an earlier series Dragan Simic
2024-03-25 20:34 ` [PATCH v3 1/3] grep: perform some minor code and comment cleanups Dragan Simic
2024-03-25 20:34 ` [PATCH v3 2/3] grep docs: describe --recurse-submodules further and improve formatting a bit Dragan Simic
2024-03-25 20:34 ` [PATCH v3 3/3] grep docs: describe --no-index " Dragan Simic
2024-03-25 20:39 ` [PATCH v3 0/3] Assorted improvements salvaged from an earlier series Eric Sunshine
2024-03-25 20:41 ` Dragan Simic
2024-03-25 20:49 ` Eric Sunshine
2024-03-25 20:54 ` Dragan Simic [this message]
2024-04-06 0:52 ` Dragan Simic
2024-04-06 1:49 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a3bc4829036f5803da513fee52267c2c@manjaro.org \
--to=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).