From: Eric Sunshine <sunshine@sunshineco.com>
To: Dragan Simic <dsimic@manjaro.org>
Cc: git@vger.kernel.org, gitster@pobox.com, jn.avila@free.fr
Subject: Re: [PATCH v3 0/3] Assorted improvements salvaged from an earlier series
Date: Mon, 25 Mar 2024 16:49:43 -0400 [thread overview]
Message-ID: <CAPig+cRECapN-9_u0JoESaS7KTi-==ri7Oy+sjff-VHL7p+vHQ@mail.gmail.com> (raw)
In-Reply-To: <92cb6c057591c7192fd7eb7097336f66@manjaro.org>
On Mon, Mar 25, 2024 at 4:41 PM Dragan Simic <dsimic@manjaro.org> wrote:
> On 2024-03-25 21:39, Eric Sunshine wrote:
> > Prose description of the changes between versions is very much welcome
> > by reviewers, but please also include a range-diff[1] or interdiff[2]
> > when preparing a reroll.
>
> Ah, sorry, I didn't forget about that, but I just intended to start
> providing range-diffs for future patches. These were more like new
> versions of old patches.
The range-diff is particularly valuable exactly for this case (new
versions of old patches) since it is a "diff" between the old patches
and the new patches. Thus, it provides reviewers with a precise
summary of what changed between, say, v2 and v3 of a series, and
manifests as a concrete representation of what your prose explanation
describes.
next prev parent reply other threads:[~2024-03-25 20:49 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-25 20:34 [PATCH v3 0/3] Assorted improvements salvaged from an earlier series Dragan Simic
2024-03-25 20:34 ` [PATCH v3 1/3] grep: perform some minor code and comment cleanups Dragan Simic
2024-03-25 20:34 ` [PATCH v3 2/3] grep docs: describe --recurse-submodules further and improve formatting a bit Dragan Simic
2024-03-25 20:34 ` [PATCH v3 3/3] grep docs: describe --no-index " Dragan Simic
2024-03-25 20:39 ` [PATCH v3 0/3] Assorted improvements salvaged from an earlier series Eric Sunshine
2024-03-25 20:41 ` Dragan Simic
2024-03-25 20:49 ` Eric Sunshine [this message]
2024-03-25 20:54 ` Dragan Simic
2024-04-06 0:52 ` Dragan Simic
2024-04-06 1:49 ` Eric Sunshine
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPig+cRECapN-9_u0JoESaS7KTi-==ri7Oy+sjff-VHL7p+vHQ@mail.gmail.com' \
--to=sunshine@sunshineco.com \
--cc=dsimic@manjaro.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jn.avila@free.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).