From: Carlo Arenas <carenas@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, peff@peff.net
Subject: Re: [PATCH] osxkeychain: restrict queries to requests with a valid host
Date: Mon, 20 Apr 2020 16:20:55 -0700 [thread overview]
Message-ID: <CAPUEspiBqCGTOfEESAqY=JR5jHhARSAODjsg5rGLxWEqzFH0zw@mail.gmail.com> (raw)
In-Reply-To: <xmqqa735rbyh.fsf@gitster.c.googlers.com>
On Mon, Apr 20, 2020 at 4:09 PM Junio C Hamano <gitster@pobox.com> wrote:
>
> Just to clarify, you do not need this patch to "fix" it, as long as
> you are running up-to-date Git, right? In other words, this is more
> like a belt-and-suspender protection, isn't it?
the fixes in master do most of the work, but the way the underlying
macOS function
used works, will still randomly select a credential for cases where host=""
Carlo
next prev parent reply other threads:[~2020-04-20 23:21 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 22:43 [PATCH] osxkeychain: restrict queries to requests with a valid host Carlo Marcelo Arenas Belón
2020-04-20 23:09 ` Junio C Hamano
2020-04-20 23:20 ` Carlo Arenas [this message]
2020-04-21 1:44 ` Junio C Hamano
2020-04-21 6:15 ` Jonathan Nieder
2024-04-22 19:48 ` Calvin Wan
2024-04-23 21:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAPUEspiBqCGTOfEESAqY=JR5jHhARSAODjsg5rGLxWEqzFH0zw@mail.gmail.com' \
--to=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).