From: "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
To: git@vger.kernel.org
Cc: peff@peff.net, "Carlo Marcelo Arenas Belón" <carenas@gmail.com>
Subject: [PATCH] osxkeychain: restrict queries to requests with a valid host
Date: Mon, 20 Apr 2020 15:43:10 -0700 [thread overview]
Message-ID: <20200420224310.9989-1-carenas@gmail.com> (raw)
make sure that requests to this helper to get credentials return early if
there is no host ord the host is empty.
Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
---
contrib/credential/osxkeychain/git-credential-osxkeychain.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/contrib/credential/osxkeychain/git-credential-osxkeychain.c b/contrib/credential/osxkeychain/git-credential-osxkeychain.c
index bcd3f575a3..2264a88c41 100644
--- a/contrib/credential/osxkeychain/git-credential-osxkeychain.c
+++ b/contrib/credential/osxkeychain/git-credential-osxkeychain.c
@@ -69,6 +69,12 @@ static void find_internet_password(void)
UInt32 len;
SecKeychainItemRef item;
+ /*
+ * Require at valid host to fix CVE-2020-11008
+ */
+ if (!host || !*host)
+ return;
+
if (SecKeychainFindInternetPassword(KEYCHAIN_ARGS, &len, &buf, &item))
return;
--
2.26.2.111.gbff22aa583
next reply other threads:[~2020-04-20 22:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-20 22:43 Carlo Marcelo Arenas Belón [this message]
2020-04-20 23:09 ` [PATCH] osxkeychain: restrict queries to requests with a valid host Junio C Hamano
2020-04-20 23:20 ` Carlo Arenas
2020-04-21 1:44 ` Junio C Hamano
2020-04-21 6:15 ` Jonathan Nieder
2024-04-22 19:48 ` Calvin Wan
2024-04-23 21:39 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420224310.9989-1-carenas@gmail.com \
--to=carenas@gmail.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).