* [Outreachy]Amend error messages and prompts of various (sub)commands
@ 2022-10-15 12:22 NSENGIYUMVA WILBERFORCE
2022-10-17 13:58 ` Christian Couder
0 siblings, 1 reply; 2+ messages in thread
From: NSENGIYUMVA WILBERFORCE @ 2022-10-15 12:22 UTC (permalink / raw)
To: git
Hi team,
My first microproject is still at seen stage, so I decided to look for
a good first issue from the repo to get more familiar with the process
of patch submission and I found I would be interested in
https://github.com/gitgitgadget/git/issues/635
The Git suite CodingGuidelines suggest this about Error messages, but
I found that git-compat-util.h contains die("Cannot handle files this
big"); which breaks one of the rules
I want to change it to die("cannot handle files this big");
Someone should give me a go ahead on this
Thanks,
Wilberforce
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [Outreachy]Amend error messages and prompts of various (sub)commands
2022-10-15 12:22 [Outreachy]Amend error messages and prompts of various (sub)commands NSENGIYUMVA WILBERFORCE
@ 2022-10-17 13:58 ` Christian Couder
0 siblings, 0 replies; 2+ messages in thread
From: Christian Couder @ 2022-10-17 13:58 UTC (permalink / raw)
To: NSENGIYUMVA WILBERFORCE; +Cc: git, Hariom verma
Hi Wilberforce,
On Sat, Oct 15, 2022 at 3:08 PM NSENGIYUMVA WILBERFORCE
<nsengiyumvawilberforce@gmail.com> wrote:
>
> Hi team,
>
> My first microproject is still at seen stage, so I decided to look for
> a good first issue from the repo to get more familiar with the process
> of patch submission and I found I would be interested in
> https://github.com/gitgitgadget/git/issues/635
>
> The Git suite CodingGuidelines suggest this about Error messages, but
> I found that git-compat-util.h contains die("Cannot handle files this
> big"); which breaks one of the rules
>
> I want to change it to die("cannot handle files this big");
>
> Someone should give me a go ahead on this
You can do it if you want, but this would be a very small
contribution. This would be Ok for a microproject, but you have
already worked on one, so you should probably aim at something a bit
more complex. See the "Only ONE quality focused microproject per
applicant" section in
https://git.github.io/General-Microproject-Information/.
By the way, please put your possible mentors (Hariom and me) in Cc.
Thanks,
Christian.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-10-17 13:59 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-10-15 12:22 [Outreachy]Amend error messages and prompts of various (sub)commands NSENGIYUMVA WILBERFORCE
2022-10-17 13:58 ` Christian Couder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).