* Zsh completion: cached __git_repo_path affects shell session, breaks completion
@ 2024-04-24 13:46 D. Ben Knoble
0 siblings, 0 replies; only message in thread
From: D. Ben Knoble @ 2024-04-24 13:46 UTC (permalink / raw)
To: Git; +Cc: felipe.contreras@gmail.com
I can only reproduce this in Zsh, not with Bash (using equivalent
commands), though the caching behavior comes from Bash (fad9484f0a
(completion: cache the path to the repository, 2017-02-03)).
For example (with Zsh):
mkdir a b b/c
for d (a b); git -C $d init && git -C $d commit --allow-empty -m init
cd a
git branch foo
pushd ../b/c
git branch bar
git rebase <TAB>… # completion for bar available; C-c to abort
declare -p __git_repo_path # outputs /path/to/b/.git
popd
git branch # outputs foo, main
git rebase <TAB>… # completion candidates are bar, main!
I've only been able to observe this with rebase so far (e.g., using
switch instead doesn't seem to trigger the problem).
I wonder if all callers of __git_find_repo_path should declare `local
__git_repo_path`? That might defeat some caching, but I don't think
__git_repo_path should be set globally in a shell session, and the
script is explicitly intended to be sourced… again, though, I think
Bash does the correct thing and somehow Zsh is capturing this variable
that it shouldn't be.
--
D. Ben Knoble
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-04-24 13:46 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-04-24 13:46 Zsh completion: cached __git_repo_path affects shell session, breaks completion D. Ben Knoble
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).