From: Victoria Dye <vdye@github.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Shuqi Liang <cheskaqiqi@gmail.com>,
git@vger.kernel.org, derrickstolee@github.com
Subject: Re: [RFC][PATCH V1] diff-tree: integrate with sparse index
Date: Wed, 17 May 2023 11:47:03 -0700 [thread overview]
Message-ID: <2d99fbed-3074-be22-2b8c-a75dd22bda65@github.com> (raw)
In-Reply-To: <xmqqsfbvswci.fsf@gitster.g>
Junio C Hamano wrote:
> Victoria Dye <vdye@github.com> writes:
>
>> Note that, if you want to make
>> that change in this series, it should be done in a separate patch _before_
>> this one (since dropping the deprecated setup infrastructure isn't really
>> part of the sparse index integration).
>
> Or after this one, perhaps? I agree that the clean-up opportunity
> you found is very much unrelated to the work to teach diff-tree to
> take advantage of the sparse index.
You're right, it doesn't need to come before this patch (or belong to this
series). *If* the cleanup was done in this series, my thought was that it
would be (subjectively) better to end the series on the sparse index
integration. However, it doesn't really make a practical difference whether
the cleanup is done before or after this patch, since it's functionally
unrelated to the sparse index work.
Thanks for the clarification!
next prev parent reply other threads:[~2023-05-17 18:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-15 19:18 [RFC][PATCH V1] diff-tree: integrate with sparse index Shuqi Liang
2023-05-16 21:19 ` Victoria Dye
2023-05-16 23:14 ` Junio C Hamano
2023-05-17 18:47 ` Victoria Dye [this message]
2023-05-18 15:44 ` [PATCH v2] " Shuqi Liang
2023-05-22 19:07 ` Victoria Dye
2023-05-23 4:38 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2d99fbed-3074-be22-2b8c-a75dd22bda65@github.com \
--to=vdye@github.com \
--cc=cheskaqiqi@gmail.com \
--cc=derrickstolee@github.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).