Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Victoria Dye <vdye@github.com>
Cc: Shuqi Liang <cheskaqiqi@gmail.com>,
	git@vger.kernel.org, derrickstolee@github.com
Subject: Re: [PATCH v2] diff-tree: integrate with sparse index
Date: Tue, 23 May 2023 13:38:37 +0900	[thread overview]
Message-ID: <xmqqy1lfirw2.fsf@gitster.g> (raw)
In-Reply-To: <2a2b7223-bb5d-65f9-95bb-9be45d329c87@github.com> (Victoria Dye's message of "Mon, 22 May 2023 12:07:23 -0700")

Victoria Dye <vdye@github.com> writes:

> Shuqi Liang wrote:
>> Change since v1:
>> 
>> * Update commit message.
>> * Use existing test repo to simplify the test.
>> * Add test to ensure index won't expand regardless of 'diff-tree' a file
>> inside or outside the cone
>
> Thanks for these updates! This version looks ready for 'next' to me.

Thanks, both.  Will do so (when I get back to the keyboard---I am on
half-vacation).


      reply	other threads:[~2023-05-23  4:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-15 19:18 [RFC][PATCH V1] diff-tree: integrate with sparse index Shuqi Liang
2023-05-16 21:19 ` Victoria Dye
2023-05-16 23:14   ` Junio C Hamano
2023-05-17 18:47     ` Victoria Dye
2023-05-18 15:44 ` [PATCH v2] " Shuqi Liang
2023-05-22 19:07   ` Victoria Dye
2023-05-23  4:38     ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xmqqy1lfirw2.fsf@gitster.g \
    --to=gitster@pobox.com \
    --cc=cheskaqiqi@gmail.com \
    --cc=derrickstolee@github.com \
    --cc=git@vger.kernel.org \
    --cc=vdye@github.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).