Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: Christian Hesse <list@eworm.de>
To: Git Mailing List <git@vger.kernel.org>
Cc: Christian Hesse <mail@eworm.de>
Subject: [PATCH 1/1] imap-send: include strbuf.h
Date: Fri,  9 Feb 2024 23:26:22 +0100	[thread overview]
Message-ID: <20240209222622.102208-1-list@eworm.de> (raw)

From: Christian Hesse <mail@eworm.de>

We had this fixed in 3307f7dde2ae8f5281d0782f7291a073c9b1cdc2,
and it broke again in eea0e59ffbed6e33d171ace5be13cde9faa41639.

We make liberal use of the strbuf API functions and types, but the
inclusion of <strbuf.h> comes indirectly by including <http.h>,
which does not happen if you build with NO_CURL.

This time make the include conditional... Does that prevent from
loosing it again?

Signed-off-by: Christian Hesse <mail@eworm.de>
---
 imap-send.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/imap-send.c b/imap-send.c
index f2e1947e63..cae494c663 100644
--- a/imap-send.c
+++ b/imap-send.c
@@ -34,6 +34,8 @@ typedef void *SSL;
 #endif
 #ifdef USE_CURL_FOR_IMAP_SEND
 #include "http.h"
+#else
+#include "strbuf.h"
 #endif
 
 #if defined(USE_CURL_FOR_IMAP_SEND)
-- 
2.43.1


             reply	other threads:[~2024-02-09 22:32 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-09 22:26 Christian Hesse [this message]
2024-02-09 22:42 ` [PATCH 1/1] imap-send: include strbuf.h Junio C Hamano
2024-02-09 22:54   ` Junio C Hamano
2024-02-10 20:01     ` Christian Hesse
2024-02-11  2:42       ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2023-05-17  7:06 Christian Hesse
2023-05-17 15:49 ` Junio C Hamano
2023-05-17 16:02   ` Taylor Blau
2023-05-17 16:19     ` Junio C Hamano
2023-05-17 16:31       ` Taylor Blau
2023-05-17 20:12       ` Christian Hesse
2023-05-17 20:18         ` Christian Hesse
2023-05-18 15:56           ` Junio C Hamano
2023-05-17 16:23     ` Taylor Blau
2023-05-17 16:53       ` Junio C Hamano
2023-05-17 17:01         ` Junio C Hamano
2023-05-17 17:58           ` Taylor Blau
2023-05-17 18:06             ` rsbecker
2023-05-17 18:12               ` Junio C Hamano
2023-05-17 19:30                 ` rsbecker
2023-05-17 18:09             ` Junio C Hamano
2023-05-17 21:38               ` Taylor Blau
2023-05-18 16:01                 ` Junio C Hamano
2023-05-18 18:25                   ` Jeff King
2023-05-18 20:49                     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20240209222622.102208-1-list@eworm.de \
    --to=list@eworm.de \
    --cc=git@vger.kernel.org \
    --cc=mail@eworm.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).