Git Mailing List Archive mirror
 help / color / mirror / Atom feed
From: Taylor Blau <me@ttaylorr.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Christian Hesse <list@eworm.de>,
	git@vger.kernel.org, Christian Hesse <mail@eworm.de>
Subject: Re: [PATCH 1/1] imap-send: include strbuf.h
Date: Wed, 17 May 2023 13:58:22 -0400	[thread overview]
Message-ID: <ZGUVvjG+xou3w8YW@nand.local> (raw)
In-Reply-To: <xmqq8rdmrixc.fsf@gitster.g>

On Wed, May 17, 2023 at 10:01:35AM -0700, Junio C Hamano wrote:
> Junio C Hamano <gitster@pobox.com> writes:
>
> >>         if ! gcc -I $(pwd) -E $f | grep -q 'struct strbuf {'
> > ...
> > What does the above prove, more than what your regular compilation
> > that does not fail, tells us?
>
> It is actually worse than that, isn't it?  This does not even use
> the definition in the config.mak.uname, so it is not even matching
> your build environment.
>
> I am uncomfortable to use this as an explanation of what due
> diligence we did to convince ourselves that this fix should cover
> all similar issues.  Perhaps I am grossly misunderstanding what your
> investigation did?

Oof, yes, you are right:

    diff -u \
      <(gcc -I . -E imap-send.c) \
      <(gcc -DNO_CURL=1 -I . -E imap-send.c)

How *should* we test this?

Thanks,
Taylor

  reply	other threads:[~2023-05-17 17:58 UTC|newest]

Thread overview: 25+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17  7:06 [PATCH 1/1] imap-send: include strbuf.h Christian Hesse
2023-05-17 15:49 ` Junio C Hamano
2023-05-17 16:02   ` Taylor Blau
2023-05-17 16:19     ` Junio C Hamano
2023-05-17 16:31       ` Taylor Blau
2023-05-17 20:12       ` Christian Hesse
2023-05-17 20:18         ` Christian Hesse
2023-05-18 15:56           ` Junio C Hamano
2023-05-17 16:23     ` Taylor Blau
2023-05-17 16:53       ` Junio C Hamano
2023-05-17 17:01         ` Junio C Hamano
2023-05-17 17:58           ` Taylor Blau [this message]
2023-05-17 18:06             ` rsbecker
2023-05-17 18:12               ` Junio C Hamano
2023-05-17 19:30                 ` rsbecker
2023-05-17 18:09             ` Junio C Hamano
2023-05-17 21:38               ` Taylor Blau
2023-05-18 16:01                 ` Junio C Hamano
2023-05-18 18:25                   ` Jeff King
2023-05-18 20:49                     ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2024-02-09 22:26 Christian Hesse
2024-02-09 22:42 ` Junio C Hamano
2024-02-09 22:54   ` Junio C Hamano
2024-02-10 20:01     ` Christian Hesse
2024-02-11  2:42       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ZGUVvjG+xou3w8YW@nand.local \
    --to=me@ttaylorr.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=list@eworm.de \
    --cc=mail@eworm.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).