From: Jeff King <peff@peff.net>
To: Taylor Blau <me@ttaylorr.com>
Cc: "Hanno Böck" <hanno@hboeck.de>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org
Subject: Re: git push --quiet is not quiet
Date: Mon, 5 Jun 2023 21:57:21 -0400 [thread overview]
Message-ID: <20230606015721.GA89456@coredump.intra.peff.net> (raw)
In-Reply-To: <ZH3IufbB/mJBBKsv@nand.local>
On Mon, Jun 05, 2023 at 07:36:25AM -0400, Taylor Blau wrote:
> I mentioned this to the team that is working on spokes-receive-pack, and
> they have graciously implemented support for the quiet capability here:
>
> https://github.com/github/spokes-receive-pack/pull/49
>
> Hopefully that gets merged and rolled out soon, at which point I think
> we can call it a day here.
Ah, cool, I didn't realize the implementation was open source. That pull
request looks like what I'd expect (from my obviously brief look at the
code).
I wondered that it did not pass along any kind of "quiet" designation to
the hooks (who might want to be less chatty in that case). But it
doesn't look like git-receive-pack does, either. So at least
spokes-receive-pack will be on par with git.git. :)
I do think it would be a potentially useful feature for receive-pack to
pass on the information that it got a "quiet" capability request from
the client (probably through the environment). But if people aren't
complaining about it, it's probably not a high priority. The only
discussion I could find was this thread from a few years ago:
https://lore.kernel.org/git/ba70b25b-906c-0117-2594-c606595c6816@redhat.com/
but it didn't result in a patch (the code change itself is probably a
one-liner setenv(), but we'd want documentation, tests, etc).
-Peff
prev parent reply other threads:[~2023-06-06 1:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 8:15 git push --quiet is not quiet Hanno Böck
2023-05-19 8:59 ` Kristoffer Haugsbakk
2023-05-19 9:05 ` Jeff King
2023-05-19 9:09 ` Hanno Böck
2023-05-19 20:42 ` Jeff King
2023-06-05 11:36 ` Taylor Blau
2023-06-06 1:57 ` Jeff King [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230606015721.GA89456@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=hanno@hboeck.de \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).