From: Jeff King <peff@peff.net>
To: "Hanno Böck" <hanno@hboeck.de>
Cc: Taylor Blau <me@ttaylorr.com>,
"brian m. carlson" <sandals@crustytoothpaste.net>,
git@vger.kernel.org
Subject: Re: git push --quiet is not quiet
Date: Fri, 19 May 2023 16:42:08 -0400 [thread overview]
Message-ID: <20230519204208.GA4001861@coredump.intra.peff.net> (raw)
In-Reply-To: <20230519110937.7df62fd7.hanno@hboeck.de>
On Fri, May 19, 2023 at 11:09:37AM +0200, Hanno Böck wrote:
> > So I think this is a bug / lack of feature in GitHub's server
> > implementation. It used to be a thin proxy around Git (and Git has
> > supported "quiet" since c207e34f7733 in 2012). But I suspect they may
> > have recently replaced it with something more custom (based on the
> > agent field).
>
> Ok, interesting. Maybe add to this: it appears github sometimes uses
> this channel to send relevant messages, e.g. dependabot alerts. Which I
> guess is a good thing, but it probably shouldn't send status messages
> for normal commits when the user asks for "quiet".
Yeah, that makes sense. Hooks should respect the "quiet" flag, too, as
appropriate. But the problem here is that because the server does not
claim to support the "quiet" capability, the client is not even passing
along the message that the user asked for "--quiet".
Presumably once that is fixed, the custom messages from the server would
then respect the quiet flag. But it's possible there might be more work
needed there, too.
-Peff
next prev parent reply other threads:[~2023-05-19 20:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-19 8:15 git push --quiet is not quiet Hanno Böck
2023-05-19 8:59 ` Kristoffer Haugsbakk
2023-05-19 9:05 ` Jeff King
2023-05-19 9:09 ` Hanno Böck
2023-05-19 20:42 ` Jeff King [this message]
2023-06-05 11:36 ` Taylor Blau
2023-06-06 1:57 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230519204208.GA4001861@coredump.intra.peff.net \
--to=peff@peff.net \
--cc=git@vger.kernel.org \
--cc=hanno@hboeck.de \
--cc=me@ttaylorr.com \
--cc=sandals@crustytoothpaste.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).