From: Toon Claes <toon@iotcl.com>
To: git@vger.kernel.org
Cc: Phillip Wood <phillip.wood123@gmail.com>, Toon Claes <toon@iotcl.com>
Subject: [PATCH v5 0/1] cat-file: quote-format name in error when using -z
Date: Wed, 10 May 2023 21:01:15 +0200 [thread overview]
Message-ID: <20230510190116.795641-1-toon@iotcl.com> (raw)
In-Reply-To: <xmqqilfhctrr.fsf@gitster.g>
This is the fifth revision of this patch. The code changes are identical to v3,
but there was one comment[1] about adding test coverage for
batch_object_write(). In v4 I tried another approach, but that didn't work well.
So for this version I'm just adding the test to version 3 as requested. See
below the range-diff against v3, ignoring v4 ever happened.
Kind regards,
Toon
[1]: https://public-inbox.org/git/2a2a46f0-a9bc-06a6-72e1-28800518777c@dunelm.org.uk/
Toon Claes (1):
cat-file: quote-format name in error when using -z
builtin/cat-file.c | 19 +++++++++++++++++++
t/t1006-cat-file.sh | 27 +++++++++++++++++++++++++++
2 files changed, 46 insertions(+)
Range-diff against v3:
1: 16f7a123d8 ! 1: 14bccfa9fd cat-file: quote-format name in error when using -z
@@ t/t1006-cat-file.sh: test_expect_success FUNNYNAMES '--batch-check, -z with newl
+ printf "\"HEAD:newline\\\\nmissing\" missing\n" >expect &&
+ test_cmp expect actual
+'
++
++test_expect_success FUNNYNAMES '--batch-check, -z with missing object having newline in name' '
++ git init missing-object-newline &&
++ (
++ cd missing-object-newline &&
++ file="newline${LF}embedded" &&
++ echo_without_newline "hello" > $file &&
++ git add "$file" &&
++ git commit -m "file with newline embedded" &&
++ test_tick &&
++
++ sha1=$(git rev-parse HEAD:"$file") &&
++ rm .git/objects/$(test_oid_to_path $sha1) &&
++ printf "HEAD:$file" >in &&
++ git cat-file --batch-check -z <in >actual &&
++ printf "\"HEAD:newline\\\\nembedded\" missing\n" >expect &&
++ test_cmp expect actual
++ )
++'
+
batch_command_multiple_info="info $hello_sha1
info $tree_sha1
--
2.40.1
next prev parent reply other threads:[~2023-05-10 19:10 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-09 15:00 [PATCH 0/1] cat-file: quote-format name in error when using -z Toon Claes
2022-12-09 15:00 ` [PATCH 1/1] " Toon Claes
2022-12-09 19:33 ` Phillip Wood
2022-12-09 23:58 ` Junio C Hamano
2022-12-11 16:30 ` Phillip Wood
2022-12-12 0:11 ` Junio C Hamano
2022-12-12 11:34 ` Toon Claes
2022-12-12 22:09 ` Junio C Hamano
2022-12-13 15:06 ` Phillip Wood
2022-12-14 8:29 ` Junio C Hamano
2022-12-20 5:31 ` Toon Claes
2022-12-20 10:18 ` Phillip Wood
2022-12-21 12:42 ` Toon Claes
2023-01-05 6:24 ` [PATCH v2 0/1] " Toon Claes
2023-01-05 6:24 ` [PATCH v2 1/1] " Toon Claes
2023-01-16 19:07 ` [PATCH v3 0/1] " Toon Claes
2023-01-16 19:07 ` [PATCH v3 1/1] " Toon Claes
2023-01-17 15:24 ` Phillip Wood
2023-03-03 19:17 ` [PATCH v4 0/2] " Toon Claes
2023-03-03 19:17 ` [PATCH v4 1/2] cat-file: extract printing batch error message into function Toon Claes
2023-03-03 20:26 ` Junio C Hamano
2023-03-03 23:14 ` Junio C Hamano
2023-05-10 19:01 ` Toon Claes [this message]
2023-05-10 19:01 ` [PATCH v5 1/1] cat-file: quote-format name in error when using -z Toon Claes
2023-05-10 20:13 ` Junio C Hamano
2023-05-12 8:54 ` Toon Claes
2023-05-12 16:57 ` Junio C Hamano
2023-05-15 8:47 ` Phillip Wood
2023-05-15 17:20 ` Junio C Hamano
2023-06-02 13:29 ` Phillip Wood
2023-03-03 19:17 ` [PATCH v4 2/2] " Toon Claes
2023-03-03 20:14 ` [PATCH v4 0/2] " Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230510190116.795641-1-toon@iotcl.com \
--to=toon@iotcl.com \
--cc=git@vger.kernel.org \
--cc=phillip.wood123@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).