dri-devel Archive mirror
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Easwar Hariharan <eahariha@linux.microsoft.com>
Cc: "open list:RADEON and AMDGPU DRM DRIVERS"
	<amd-gfx@lists.freedesktop.org>,
	"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
	 open list <linux-kernel@vger.kernel.org>,
	 "open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
	<intel-gfx@lists.freedesktop.org>,
	 "open list:INTEL DRM DISPLAY FOR XE AND I915 DRIVERS"
	<intel-xe@lists.freedesktop.org>,
	 "open list:DRM DRIVER FOR NVIDIA GEFORCE/QUADRO GPUS"
	<nouveau@lists.freedesktop.org>,
	 "open list:I2C SUBSYSTEM HOST DRIVERS"
	<linux-i2c@vger.kernel.org>,
	 "open list:BTTV VIDEO4LINUX DRIVER"
	<linux-media@vger.kernel.org>,
	"open list:FRAMEBUFFER LAYER" <linux-fbdev@vger.kernel.org>
Subject: Re: [PATCH v0 00/14] Make I2C terminology more inclusive for I2C Algobit and consumers
Date: Fri, 5 Apr 2024 12:18:37 +0200	[thread overview]
Message-ID: <ffumcagmzdstcf3qcn3f26555pnu7i6azjppciyd4zvcoit7pv@vu262tsfnqyr> (raw)
In-Reply-To: <20240329170038.3863998-1-eahariha@linux.microsoft.com>

[-- Attachment #1: Type: text/plain, Size: 1975 bytes --]

Hello Easwar,

On Fri, Mar 29, 2024 at 05:00:24PM +0000, Easwar Hariharan wrote:
> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave"
> with more appropriate terms. Inspired by and following on to Wolfram's
> series to fix drivers/i2c/[1], fix the terminology for users of the
> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
> in the specification.

I really appreciate that you want to assist in this task to improve the
I2C core. I do. I am afraid, however, that you took the second step
before the first one, though. As I mentioned in my original cover
letter, this is not only about renaming but also improving the I2C API
(splitting up header files...). So, drivers are not a priority right
now. They can be better fixed once the core is ready.

It is true that I changed quite some controller drivers within the i2c
realm. I did this to gain experience. As you also noticed quite some
questions came up. We need to agree on answers first. And once we are
happy with the answers we found, then IMO we can go outside of the i2c
realm and send patches to other subsystems referencing agreed
precedence. I intentionally did not go outside i2c yet. Since your
patches are already there, you probably want to foster them until they
are ready for inclusion. Yet, regarding further patches, my suggestion
is to wait until the core is ready. That might take a while, though.
However, there is enough to discuss until the core is ready. So, your
collaboration there is highly appreciated!

> The last patch updating the .master_xfer method to .xfer depends on
> patch 1 of Wolfram's series below, but the series is otherwise
> independent. It may make sense for the last patch to go in with

Please drop the last patch from this series. It will nicely remove the
dependency. Also, like above, I first want to gain experience with i2c
before going to other subsystems. That was intended.

All the best and happy hacking,

   Wolfram


[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

  parent reply	other threads:[~2024-04-05 10:25 UTC|newest]

Thread overview: 48+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-29 17:00 [PATCH v0 00/14] Make I2C terminology more inclusive for I2C Algobit and consumers Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 01/14] IB/hfi1, IB/qib: Make I2C terminology more inclusive Easwar Hariharan
2024-04-03  8:30   ` Leon Romanovsky
2024-04-03 15:54     ` Dennis Dalessandro
2024-04-03 16:44       ` Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 02/14] drm/amdgpu, drm/radeon: " Easwar Hariharan
2024-03-29 17:16   ` [PATCH v0 02/14] drm/amdgpu,drm/radeon: " Andi Shyti
2024-03-29 17:28     ` [PATCH v0 02/14] drm/amdgpu, drm/radeon: " Easwar Hariharan
2024-03-29 17:38       ` [PATCH v0 02/14] drm/amdgpu,drm/radeon: " Andi Shyti
2024-03-29 18:51         ` [PATCH v0 02/14] drm/amdgpu, drm/radeon: " Easwar Hariharan
2024-04-03 12:36         ` [PATCH v0 02/14] drm/amdgpu,drm/radeon: " Ville Syrjälä
2024-04-03 13:12           ` Jani Nikula
2024-04-03 14:26             ` [PATCH v0 02/14] drm/amdgpu, drm/radeon: " Christian König
2024-04-03 16:43               ` Easwar Hariharan
2024-04-03 16:42             ` Easwar Hariharan
2024-03-29 17:38       ` Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 03/14] drm/gma500, drm/i915: " Easwar Hariharan
2024-04-02  7:48   ` [PATCH v0 03/14] drm/gma500,drm/i915: " Jani Nikula
2024-04-02 11:59     ` Easwar Hariharan
2024-04-02 14:32       ` Jani Nikula
2024-04-02 16:20         ` Easwar Hariharan
2024-04-02 16:52           ` Jani Nikula
2024-04-02 18:19             ` Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 04/14] media: au0828: " Easwar Hariharan
2024-05-03 19:03   ` Mauro Carvalho Chehab
2024-03-29 17:00 ` [PATCH v0 05/14] media: cobalt: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 06/14] media: cx18: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 07/14] media: cx25821: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 08/14] media: ivtv: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 09/14] media: cx23885: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 10/14] sfc: falcon: " Easwar Hariharan
2024-04-02  8:29   ` Simon Horman
2024-04-04 19:17     ` Easwar Hariharan
2024-04-07  8:49       ` Simon Horman
2024-04-02  9:00   ` Martin Habets
2024-04-04 19:18     ` Easwar Hariharan
2024-04-08  8:35       ` Martin Habets
2024-03-29 17:00 ` [PATCH v0 11/14] fbdev/smscufx: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 12/14] fbdev/viafb: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 13/14] drm/nouveau: " Easwar Hariharan
2024-04-05 16:15   ` Danilo Krummrich
2024-04-05 16:30     ` Easwar Hariharan
2024-04-05 18:36       ` Lyude Paul
2024-03-29 17:00 ` [PATCH v0 14/14] i2c and treewide: " Easwar Hariharan
2024-04-05 10:18 ` Wolfram Sang [this message]
2024-04-05 17:09   ` [PATCH v0 00/14] Make I2C terminology more inclusive for I2C Algobit and consumers Easwar Hariharan
2024-04-07 17:50     ` Wolfram Sang
2024-04-08  7:48   ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=ffumcagmzdstcf3qcn3f26555pnu7i6azjppciyd4zvcoit7pv@vu262tsfnqyr \
    --to=wsa+renesas@sang-engineering.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=eahariha@linux.microsoft.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=intel-xe@lists.freedesktop.org \
    --cc=linux-fbdev@vger.kernel.org \
    --cc=linux-i2c@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).