From: Easwar Hariharan <eahariha@linux.microsoft.com>
To: "Jani Nikula" <jani.nikula@linux.intel.com>,
"Ville Syrjälä" <ville.syrjala@linux.intel.com>,
"Andi Shyti" <andi.shyti@linux.intel.com>
Cc: "Alex Deucher" <alexander.deucher@amd.com>,
"Christian König" <christian.koenig@amd.com>,
"Pan, Xinhui" <Xinhui.Pan@amd.com>,
"David Airlie" <airlied@gmail.com>,
"Daniel Vetter" <daniel@ffwll.ch>,
"Harry Wentland" <harry.wentland@amd.com>,
"Leo Li" <sunpeng.li@amd.com>,
"Rodrigo Siqueira" <Rodrigo.Siqueira@amd.com>,
"Evan Quan" <evan.quan@amd.com>,
"Hawking Zhang" <Hawking.Zhang@amd.com>,
"Candice Li" <candice.li@amd.com>,
"Ran Sun" <sunran001@208suo.com>,
"Alexander Richards" <electrodeyt@gmail.com>,
"AngeloGioacchino Del Regno"
<angelogioacchino.delregno@collabora.com>,
"Neil Armstrong" <neil.armstrong@linaro.org>,
"Heiner Kallweit" <hkallweit1@gmail.com>,
"Hamza Mahfooz" <hamza.mahfooz@amd.com>,
"Ruan Jinjie" <ruanjinjie@huawei.com>,
"Alan Liu" <haoping.liu@amd.com>,
"Aurabindo Pillai" <aurabindo.pillai@amd.com>,
"Wayne Lin" <wayne.lin@amd.com>,
"Samson Tam" <samson.tam@amd.com>,
"Alvin Lee" <alvin.lee2@amd.com>,
"Charlene Liu" <charlene.liu@amd.com>,
"Sohaib Nadeem" <sohaib.nadeem@amd.com>,
"Lewis Huang" <lewis.huang@amd.com>,
"Tom Chung" <chiahsuan.chung@amd.com>,
"Bhawanpreet Lakha" <Bhawanpreet.Lakha@amd.com>,
"Meenakshikumar Somasundaram"
<meenakshikumar.somasundaram@amd.com>,
"George Shen" <george.shen@amd.com>,
"Aric Cyr" <aric.cyr@amd.com>, "Jun Lei" <jun.lei@amd.com>,
"Nicholas Kazlauskas" <nicholas.kazlauskas@amd.com>,
"Qingqing Zhuo" <Qingqing.Zhuo@amd.com>,
"Dillon Varone" <dillon.varone@amd.com>, "Le Ma" <Le.Ma@amd.com>,
"Lijo Lazar" <lijo.lazar@amd.com>,
"Asad kamal" <asad.kamal@amd.com>,
"Kenneth Feng" <kenneth.feng@amd.com>, "Ma Jun" <Jun.Ma2@amd.com>,
"Mario Limonciello" <mario.limonciello@amd.com>,
"Yang Wang" <kevinyang.wang@amd.com>,
"Darren Powell" <darren.powell@amd.com>,
"Yifan Zhang" <yifan1.zhang@amd.com>,
"open list:RADEON and AMDGPU DRM DRIVERS"
<amd-gfx@lists.freedesktop.org>,
"open list:DRM DRIVERS" <dri-devel@lists.freedesktop.org>,
"open list" <linux-kernel@vger.kernel.org>,
"Wolfram Sang" <wsa@kernel.org>
Subject: Re: [PATCH v0 02/14] drm/amdgpu, drm/radeon: Make I2C terminology more inclusive
Date: Wed, 3 Apr 2024 09:42:25 -0700 [thread overview]
Message-ID: <8f475409-d56d-45b4-8310-4c2122a43eb7@linux.microsoft.com> (raw)
In-Reply-To: <87sf02d1zf.fsf@intel.com>
On 4/3/2024 6:12 AM, Jani Nikula wrote:
> On Wed, 03 Apr 2024, Ville Syrjälä <ville.syrjala@linux.intel.com> wrote:
>> On Fri, Mar 29, 2024 at 06:38:10PM +0100, Andi Shyti wrote:
>>> Hi,
>>>
>>> On Fri, Mar 29, 2024 at 10:28:14AM -0700, Easwar Hariharan wrote:
>>>> On 3/29/2024 10:16 AM, Andi Shyti wrote:
>>>>> Hi Easwar,
>>>>>
>>>>> On Fri, Mar 29, 2024 at 05:00:26PM +0000, Easwar Hariharan wrote:
>>>>>> I2C v7, SMBus 3.2, and I3C specifications have replaced "master/slave"
>>>>>
>>>>> I don't understand why we forget that i3c is 1.1.1 :-)
>>>>
>>>> That's because it's a copy-paste error from Wolfram's cover letter. :) I'll update
>>>> next go-around.
>>>
>>> not a binding comment, though. Just for completeness, because we
>>> are giving the version to the i2c and smbus, but not i3c.
>>>
>>>>>> with more appropriate terms. Inspired by and following on to Wolfram's
>>>>>> series to fix drivers/i2c/[1], fix the terminology for users of
>>>>>> I2C_ALGOBIT bitbanging interface, now that the approved verbiage exists
>>>>>> in the specification.
>>>>>
>>>>> The specification talks about:
>>>>>
>>>>> - master -> controller
>>>>> - slave -> target (and not client)
>>>>>
>>>>> But both you and Wolfram have used client. I'd like to reach
>>>>> some more consistency here.
>>>>
>>>> I had the impression that remote targets (i.e external to the device) were to be called clients,
>>>> e.g. the QSFP FRUs in drivers/infiniband, and internal ones targets.
>>>> I chose the terminology according to that understanding, but now I can't find where I got that
>>>> information.
>>>
>>> The word "client" does not even appear in the documentation (only
>>> one instance in the i3c document), so that the change is not
>>> related to the document as stated in the commit log. Unless, of
>>> course, I am missing something.
>>>
>>> I'm OK with choosing a "customized" naming, but we need to reach
>>> an agreement.
>>>
>>> I raised the same question to Wolfram.
>>
>> I don't know where that discussion happened, but my opinion
>> is NAK to "client". Life is already confusing enough with
>> these renames, so let's not make it even more confusing by
>> inventing new names nowhere to be found in the spec.
>>
>> And let's especially not invent names that don't even fit
>> the purpose. "Client" makes me think of "client/server" or
>> some real world analogy. Neither of which seem to have any
>> resemblence to how the term would be used for i2c.
>
> Agreed.
>
> I2C 7.0, I3C 1.1.1, and SMBus 3.2 have all switched to controller/target
> terminology. The SMBus spec has additionally converted generic host
> references to controller.
>
> At least for i915 where I have some say in the matter, controller/target
> it shall be.
>
>
> BR,
> Jani.
>
>
Will do in v1. Thanks for the review, Jani and Ville.
Thanks,
Easwar
next prev parent reply other threads:[~2024-04-03 16:42 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 17:00 [PATCH v0 00/14] Make I2C terminology more inclusive for I2C Algobit and consumers Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 01/14] IB/hfi1, IB/qib: Make I2C terminology more inclusive Easwar Hariharan
2024-04-03 8:30 ` Leon Romanovsky
2024-04-03 15:54 ` Dennis Dalessandro
2024-04-03 16:44 ` Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 02/14] drm/amdgpu, drm/radeon: " Easwar Hariharan
2024-03-29 17:16 ` [PATCH v0 02/14] drm/amdgpu,drm/radeon: " Andi Shyti
2024-03-29 17:28 ` [PATCH v0 02/14] drm/amdgpu, drm/radeon: " Easwar Hariharan
2024-03-29 17:38 ` [PATCH v0 02/14] drm/amdgpu,drm/radeon: " Andi Shyti
2024-03-29 18:51 ` [PATCH v0 02/14] drm/amdgpu, drm/radeon: " Easwar Hariharan
2024-04-03 12:36 ` [PATCH v0 02/14] drm/amdgpu,drm/radeon: " Ville Syrjälä
2024-04-03 13:12 ` Jani Nikula
2024-04-03 14:26 ` [PATCH v0 02/14] drm/amdgpu, drm/radeon: " Christian König
2024-04-03 16:43 ` Easwar Hariharan
2024-04-03 16:42 ` Easwar Hariharan [this message]
2024-03-29 17:38 ` Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 03/14] drm/gma500, drm/i915: " Easwar Hariharan
2024-04-02 7:48 ` [PATCH v0 03/14] drm/gma500,drm/i915: " Jani Nikula
2024-04-02 11:59 ` Easwar Hariharan
2024-04-02 14:32 ` Jani Nikula
2024-04-02 16:20 ` Easwar Hariharan
2024-04-02 16:52 ` Jani Nikula
2024-04-02 18:19 ` Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 04/14] media: au0828: " Easwar Hariharan
2024-05-03 19:03 ` Mauro Carvalho Chehab
2024-03-29 17:00 ` [PATCH v0 05/14] media: cobalt: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 06/14] media: cx18: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 07/14] media: cx25821: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 08/14] media: ivtv: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 09/14] media: cx23885: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 10/14] sfc: falcon: " Easwar Hariharan
2024-04-02 8:29 ` Simon Horman
2024-04-04 19:17 ` Easwar Hariharan
2024-04-07 8:49 ` Simon Horman
2024-04-02 9:00 ` Martin Habets
2024-04-04 19:18 ` Easwar Hariharan
2024-04-08 8:35 ` Martin Habets
2024-03-29 17:00 ` [PATCH v0 11/14] fbdev/smscufx: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 12/14] fbdev/viafb: " Easwar Hariharan
2024-03-29 17:00 ` [PATCH v0 13/14] drm/nouveau: " Easwar Hariharan
2024-04-05 16:15 ` Danilo Krummrich
2024-04-05 16:30 ` Easwar Hariharan
2024-04-05 18:36 ` Lyude Paul
2024-03-29 17:00 ` [PATCH v0 14/14] i2c and treewide: " Easwar Hariharan
2024-04-05 10:18 ` [PATCH v0 00/14] Make I2C terminology more inclusive for I2C Algobit and consumers Wolfram Sang
2024-04-05 17:09 ` Easwar Hariharan
2024-04-07 17:50 ` Wolfram Sang
2024-04-08 7:48 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f475409-d56d-45b4-8310-4c2122a43eb7@linux.microsoft.com \
--to=eahariha@linux.microsoft.com \
--cc=Bhawanpreet.Lakha@amd.com \
--cc=Hawking.Zhang@amd.com \
--cc=Jun.Ma2@amd.com \
--cc=Le.Ma@amd.com \
--cc=Qingqing.Zhuo@amd.com \
--cc=Rodrigo.Siqueira@amd.com \
--cc=Xinhui.Pan@amd.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alvin.lee2@amd.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=andi.shyti@linux.intel.com \
--cc=angelogioacchino.delregno@collabora.com \
--cc=aric.cyr@amd.com \
--cc=asad.kamal@amd.com \
--cc=aurabindo.pillai@amd.com \
--cc=candice.li@amd.com \
--cc=charlene.liu@amd.com \
--cc=chiahsuan.chung@amd.com \
--cc=christian.koenig@amd.com \
--cc=daniel@ffwll.ch \
--cc=darren.powell@amd.com \
--cc=dillon.varone@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=electrodeyt@gmail.com \
--cc=evan.quan@amd.com \
--cc=george.shen@amd.com \
--cc=hamza.mahfooz@amd.com \
--cc=haoping.liu@amd.com \
--cc=harry.wentland@amd.com \
--cc=hkallweit1@gmail.com \
--cc=jani.nikula@linux.intel.com \
--cc=jun.lei@amd.com \
--cc=kenneth.feng@amd.com \
--cc=kevinyang.wang@amd.com \
--cc=lewis.huang@amd.com \
--cc=lijo.lazar@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mario.limonciello@amd.com \
--cc=meenakshikumar.somasundaram@amd.com \
--cc=neil.armstrong@linaro.org \
--cc=nicholas.kazlauskas@amd.com \
--cc=ruanjinjie@huawei.com \
--cc=samson.tam@amd.com \
--cc=sohaib.nadeem@amd.com \
--cc=sunpeng.li@amd.com \
--cc=sunran001@208suo.com \
--cc=ville.syrjala@linux.intel.com \
--cc=wayne.lin@amd.com \
--cc=wsa@kernel.org \
--cc=yifan1.zhang@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).