From: Greg KH <gregkh@linuxfoundation.org>
To: cluster-devel.redhat.com
Subject: [Cluster-devel] [PATCH dlm/next] fs: dlm: fix nfs async lock callback handling
Date: Wed, 7 Jun 2023 09:35:52 +0200 [thread overview]
Message-ID: <2023060744-raft-gizzard-ad1d@gregkh> (raw)
In-Reply-To: <20230606215626.327239-1-aahringo@redhat.com>
On Tue, Jun 06, 2023 at 05:56:26PM -0400, Alexander Aring wrote:
> This patch is fixing the current the callback handling if it's a nfs
> async lock request signaled if fl_lmops is set.
>
> When using `stress-ng --fcntl 32` on the kernel log there are several
> messages like:
>
> [11185.123533] dlm: dlm_plock_callback: vfs lock error 5d5127 file 000000002dd10f4d fl 000000007d13afae
> [11185.127135] dlm: dlm_plock_callback: vfs lock error 5d5127 file 000000002dd10f4d fl 00000000a6046fa0
> [11185.142668] dlm: dlm_plock_callback: vfs lock error 5d5127 file 000000002dd10f4d fl 000000001d13dfa5
>
> The commit 40595cdc93ed ("nfs: block notification on fs with its
> own ->lock") using only trylocks in an asynchronous polling behaviour. The
> behaviour before was however differently by evaluating F_SETLKW or F_SETLK
> and evaluating FL_SLEEP which was the case before commit 40595cdc93ed
> ("nfs: block notification on fs with its own ->lock"). This behaviour
> seems to be broken before. This patch will fix the behaviour for the
> special nfs case before commit 40595cdc93ed ("nfs: block notification on
> fs with its own ->lock").
>
> There is still a TODO of solving the case when an nfs locking request
> got interrupted.
>
> Fixes: 40595cdc93ed ("nfs: block notification on fs with its own ->lock")
> Signed-off-by: Alexander Aring <aahringo@redhat.com>
> ---
> fs/dlm/plock.c | 22 +---------------------
> 1 file changed, 1 insertion(+), 21 deletions(-)
>
<formletter>
This is not the correct way to submit patches for inclusion in the
stable kernel tree. Please read:
https://www.kernel.org/doc/html/latest/process/stable-kernel-rules.html
for how to do this properly.
</formletter>
prev parent reply other threads:[~2023-06-07 7:35 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-06 21:56 [Cluster-devel] [PATCH dlm/next] fs: dlm: fix nfs async lock callback handling Alexander Aring
2023-06-06 21:58 ` Alexander Aring
2023-06-07 7:35 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2023060744-raft-gizzard-ad1d@gregkh \
--to=gregkh@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).