From: Daniel Wagner <dwagner@suse.de>
To: Keith Busch <kbusch@kernel.org>
Cc: Kamaljit Singh <Kamaljit.Singh1@wdc.com>,
Christoph Hellwig <hch@lst.de>,
"linux-nvme@lists.infradead.org"
<linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"axboe@fb.com" <axboe@fb.com>, Gregory Joyce <gjoyce@ibm.com>,
Nilay Shroff <nilay@linux.ibm.com>
Subject: Re: [Bug Report] nvme-cli commands fails to open head disk node and print error
Date: Wed, 3 Apr 2024 12:10:22 +0200 [thread overview]
Message-ID: <sc3b5fckqc27gmpb4ifz2tcr3oxo7hm24gu3ktfwk2jg2bhifm@rvw6u5oq77pw> (raw)
In-Reply-To: <ZgzIC-9buT_UKaeW@kbusch-mbp.dhcp.thefacebook.com>
On Tue, Apr 02, 2024 at 09:07:55PM -0600, Keith Busch wrote:
> On Tue, Apr 02, 2024 at 10:07:25PM +0000, Kamaljit Singh wrote:
> > Your question about the nvme-cli version makes me wonder if there is a
> > version compatibility matrix (nvme-cli vs kernel) somewhere you could
> > point me to? I didn't see such info in the nvme-cli release notes.
>
> I don't believe there's ever been an intentional incompatibility for
> nvme-cli vs. kernel versions. Most of the incompatibility problems come
> from sysfs dependencies, but those should not be necessary for the core
> passthrough commands on any version pairing.
>
> And yeah, there should be sane fallbacks for older kernels in case a new
> feature introduces a regression, but it's not always perfect. We try to
> fix them as we learn about them, so bug reports on the github are useful
> for tracking that.
Indeed, all new features are auto detected. So if the kernel provides
them, nvme-cli/libnvme will be able to use them. Obviously, sometimes
there are some regressions but we avoid to increase the minimum kernel
dependency. Many things are also behind CONFIG options, thus the only
viable way is to auto detect features. Note, these new features are
almost all exclusive in the fabric code base. The PCI related bits are
pretty stable.
> > For example, I've seen issues with newer than nvme-cli v1.16 on Ubuntu
> > 22.04 (stock & newer kernels). From a compatibility perspective I do
> > wonder whether circumventing a distro's package manager and directly
> > installing newer nvme-cli versions might be a bad idea. This could
> > possibly become dire if there were intentional version dependencies
> > across the stack.
>
> The struggle is real, isn't it? New protocol features are added upstream
> faster than distro package updates provide their users. On the other
> hand, distros may be cautious to potential instability.
We got a lot of request to provide up to data binaries for old distros.
For this reason we have an AppImage binary to play around. So if you
want to play with the latest greatest, it's fairly simple to do so.
next prev parent reply other threads:[~2024-04-03 10:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 6:30 [Bug Report] nvme-cli commands fails to open head disk node and print error Nilay Shroff
2024-03-28 7:15 ` Christoph Hellwig
2024-03-28 10:25 ` Nilay Shroff
2024-03-28 8:45 ` Daniel Wagner
2024-03-28 10:05 ` Nilay Shroff
2024-04-02 22:07 ` Kamaljit Singh
2024-04-03 3:07 ` Keith Busch
2024-04-03 10:10 ` Daniel Wagner [this message]
2024-04-02 15:04 ` Christoph Hellwig
2024-04-03 7:03 ` Nilay Shroff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=sc3b5fckqc27gmpb4ifz2tcr3oxo7hm24gu3ktfwk2jg2bhifm@rvw6u5oq77pw \
--to=dwagner@suse.de \
--cc=Kamaljit.Singh1@wdc.com \
--cc=axboe@fb.com \
--cc=gjoyce@ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=nilay@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.