From: Nilay Shroff <nilay@linux.ibm.com>
To: Christoph Hellwig <hch@lst.de>
Cc: Keith Busch <kbusch@kernel.org>,
linux-nvme@lists.infradead.org, linux-block@vger.kernel.org,
axboe@fb.com, Gregory Joyce <gjoyce@ibm.com>
Subject: Re: [Bug Report] nvme-cli commands fails to open head disk node and print error
Date: Wed, 3 Apr 2024 12:33:05 +0530 [thread overview]
Message-ID: <ff149ec9-9664-4d72-bbe5-1db2520df33b@linux.ibm.com> (raw)
In-Reply-To: <20240402150446.GB1916@lst.de>
Hi Christoph,
On 4/2/24 20:34, Christoph Hellwig wrote:
> Hi Nilay,
>
> can you see if this patch makes a different for your weird controller
> with the listed but zero capacity namespaces?
>
> diff --git a/drivers/nvme/host/core.c b/drivers/nvme/host/core.c
> index 3b0498f320e6b9..ad60cf5581a419 100644
> --- a/drivers/nvme/host/core.c
> +++ b/drivers/nvme/host/core.c
> @@ -2089,7 +2089,7 @@ static int nvme_update_ns_info_block(struct nvme_ns *ns,
> if (id->ncap == 0) {
> /* namespace not allocated or attached */
> info->is_removed = true;
> - ret = -ENODEV;
> + ret = -ENXIO;
> goto out;
> }
> lbaf = nvme_lbaf_index(id->flbas);
>
I have just tested the above patch on my controller which has zero
capacity namespaces. The patch works as expected and I don't encounter
any errors while using nvme-cli commands. Please note that I am using
here the old version of nvme-cli (nvme version 2.6 / libnvme version 1.6).
Furthermore, with this patch, I no longer find any hidden disk nodes
(i.e. nvmeXcYnZ or nvmeXnY) created for namespaces with zero capacity
under /sys/block. So the behavior is similar to that of kernel v6.8.
IMO, we should upstream this patch.
Thanks,
--Nilay
prev parent reply other threads:[~2024-04-03 7:03 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-28 6:30 [Bug Report] nvme-cli commands fails to open head disk node and print error Nilay Shroff
2024-03-28 7:15 ` Christoph Hellwig
2024-03-28 10:25 ` Nilay Shroff
2024-03-28 8:45 ` Daniel Wagner
2024-03-28 10:05 ` Nilay Shroff
2024-04-02 22:07 ` Kamaljit Singh
2024-04-03 3:07 ` Keith Busch
2024-04-03 10:10 ` Daniel Wagner
2024-04-02 15:04 ` Christoph Hellwig
2024-04-03 7:03 ` Nilay Shroff [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ff149ec9-9664-4d72-bbe5-1db2520df33b@linux.ibm.com \
--to=nilay@linux.ibm.com \
--cc=axboe@fb.com \
--cc=gjoyce@ibm.com \
--cc=hch@lst.de \
--cc=kbusch@kernel.org \
--cc=linux-block@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.