All the mail mirrored from lore.kernel.org
 help / color / mirror / Atom feed
From: Alexey Minnekhanov <alexeymin@postmarketos.org>
To: Martin Botka <martin.botka@somainline.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
	konrad.dybcio@somainline.org,
	angelogioacchino.delregno@somainline.org,
	marijn.suijten@somainline.org, jamipkettunen@somainline.org,
	Andy Gross <agross@kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	Rob Herring <robh+dt@kernel.org>,
	linux-arm-msm@vger.kernel.org,
	Iskren Chernev <iskren.chernev@gmail.com>
Subject: Re: [PATCH v2 1/2] arch: arm64: dts: qcom: Add support for SM6125
Date: Sun, 13 Jun 2021 00:20:53 +0300	[thread overview]
Message-ID: <d98a8361-5ee5-cde3-03e0-8f61af6686cd@postmarketos.org> (raw)
In-Reply-To: <20210612094652.90354-1-martin.botka@somainline.org>

> +		sdhc_1: sdhci@4744000 {
> +			compatible = "qcom,sm6125-sdhci", "qcom,sdhci-msm-v5";
> +			reg = <0x04744000 0x1000>, <0x04744000 0x1000>;
> +			reg-names = "hc_mem", "core_mem";

ichernev: reg-names should be "hc" and "cqhci" and the 2 values you've 
supplied should be different maybe?

> +
> +		sdhc_2: sdhci@4784000 {
> +			compatible = "qcom,sm6125-sdhci", "qcom,sdhci-msm-v5";
> +			reg = <0x04784000 0x1000>;
> +			reg-names = "hc_mem";

Wrong reg names again?

-- 
Regards
Alexey Minnekhanov

  parent reply	other threads:[~2021-06-12 21:21 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-12  9:46 [PATCH v2 1/2] arch: arm64: dts: qcom: Add support for SM6125 Martin Botka
2021-06-12  9:46 ` [PATCH 2/2] arch: arm64: dts: qcom: Add support for Sony Xperia 10II Martin Botka
2021-06-12 21:20 ` Alexey Minnekhanov [this message]
2021-06-13  7:50   ` [PATCH v2 1/2] arch: arm64: dts: qcom: Add support for SM6125 Martin Botka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=d98a8361-5ee5-cde3-03e0-8f61af6686cd@postmarketos.org \
    --to=alexeymin@postmarketos.org \
    --cc=agross@kernel.org \
    --cc=angelogioacchino.delregno@somainline.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=iskren.chernev@gmail.com \
    --cc=jamipkettunen@somainline.org \
    --cc=konrad.dybcio@somainline.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=marijn.suijten@somainline.org \
    --cc=martin.botka@somainline.org \
    --cc=robh+dt@kernel.org \
    --cc=~postmarketos/upstreaming@lists.sr.ht \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.