From: Martin Botka <martin.botka@somainline.org>
To: Alexey Minnekhanov <alexeymin@postmarketos.org>
Cc: ~postmarketos/upstreaming@lists.sr.ht,
konrad.dybcio@somainline.org,
angelogioacchino.delregno@somainline.org,
marijn.suijten@somainline.org, jamipkettunen@somainline.org,
Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org,
Iskren Chernev <iskren.chernev@gmail.com>
Subject: Re: [PATCH v2 1/2] arch: arm64: dts: qcom: Add support for SM6125
Date: Sun, 13 Jun 2021 09:50:03 +0200 [thread overview]
Message-ID: <F3RMUQ.F1IP4XKK3SP92@somainline.org> (raw)
In-Reply-To: <d98a8361-5ee5-cde3-03e0-8f61af6686cd@postmarketos.org>
On Sun, Jun 13 2021 at 12:20:53 AM +0300, Alexey Minnekhanov
<alexeymin@postmarketos.org> wrote:
> > + sdhc_1: sdhci@4744000 {
>> + compatible = "qcom,sm6125-sdhci", "qcom,sdhci-msm-v5";
>> + reg = <0x04744000 0x1000>, <0x04744000 0x1000>;
>> + reg-names = "hc_mem", "core_mem";
>
> ichernev: reg-names should be "hc" and "cqhci" and the 2 values
> you've supplied should be different maybe?
>
Actually reg-names are OK to use like this. Driver will accept both hc
and hc_mem and the same for core.
The getresource function in the driver most likely checks for both as
other DTS files have hc_mem as well.
But i will change them in V3 to follow the bindings properly.
I will check if they should be different.
>> +
>> + sdhc_2: sdhci@4784000 {
>> + compatible = "qcom,sm6125-sdhci", "qcom,sdhci-msm-v5";
>> + reg = <0x04784000 0x1000>;
>> + reg-names = "hc_mem";
>
> Wrong reg names again?
>
Same as above.
Thank you for the suggestions.
Best regards,
Martin Botka
prev parent reply other threads:[~2021-06-13 7:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-06-12 9:46 [PATCH v2 1/2] arch: arm64: dts: qcom: Add support for SM6125 Martin Botka
2021-06-12 9:46 ` [PATCH 2/2] arch: arm64: dts: qcom: Add support for Sony Xperia 10II Martin Botka
2021-06-12 21:20 ` [PATCH v2 1/2] arch: arm64: dts: qcom: Add support for SM6125 Alexey Minnekhanov
2021-06-13 7:50 ` Martin Botka [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F3RMUQ.F1IP4XKK3SP92@somainline.org \
--to=martin.botka@somainline.org \
--cc=agross@kernel.org \
--cc=alexeymin@postmarketos.org \
--cc=angelogioacchino.delregno@somainline.org \
--cc=bjorn.andersson@linaro.org \
--cc=iskren.chernev@gmail.com \
--cc=jamipkettunen@somainline.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=robh+dt@kernel.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.