From: Bernhard Voelker <mail@bernhard-voelker.de>
To: "Paul Eggert" <eggert@cs.ucla.edu>, "Pádraig Brady" <P@draigBrady.com>
Cc: 69532@debbugs.gnu.org, util-linux <util-linux@vger.kernel.org>,
Dominique Martinet <asmadeus@codewreck.org>,
Petr Malat <oss@malat.biz>, Karel Zak <kzak@redhat.com>,
Rob Landley <rob@landley.net>
Subject: Re: bug#69532: mv's new -x option should be made orthogonal to -t/-T/default
Date: Thu, 21 Mar 2024 22:45:24 +0100 [thread overview]
Message-ID: <d6530404-4fc7-40d0-be99-cb37426be32d@bernhard-voelker.de> (raw)
In-Reply-To: <e1269c19-c2b9-45ac-b683-47a473326662@cs.ucla.edu>
On 3/21/24 00:56, Paul Eggert wrote:
> On 3/20/24 15:53, Bernhard Voelker wrote:
> Yes, that's the expected behavior for this contrived case. Just as one
> would get odd behavior if one did the same thing without --exchange.
There's another which is not consistent with/without --exchange:
$ src/mv -v a a
src/mv: 'a' and 'a' are the same file
$ src/mv -v --exchange a a
renamed 'a' -> 'a'
RENAME_EXCHANGE is allowed (but useless?) for 1 file.
BTW: shouldn't the -v diagnostic better say "exchanged 'a' <-> 'a'"
because that's what happened?
>> - not sure if exchange works well together with -f.
>
> What problems do you see there?
it's up to the tests to proof that.
>> why does exchange not work to exchange a regular with a
>> directory file?
>
> It works. I don't see a problem there.
>
> $ touch a
> $ mkdir d
> $ ./mv -T --exchange a d
> $ ls -ld a d
> drwxr-xr-x. 2 eggert eggert 4096 Mar 20 16:52 a
> -rw-r--r--. 1 eggert eggert 0 Mar 20 16:52 d
indeed, it works. It seems my test was wrong, sorry.
>> Finally, the test cases are very sparse:
>
> Feel free to add some. :-)
Unfortunately, I cannot currently spend as much time as I'd love to.
It seems that -i is skipped:
$ src/mv -iv --exchange a b
renamed 'a' -> 'b'
As far as I know Padraig would like to do the next release very soon,
so I would recommend to not hurrying this one into it, and instead
ironing all out after the release.
Have a nice day,
Berny
next prev parent reply other threads:[~2024-03-21 21:45 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <10c814a7-cb68-4fb4-ad8d-f88f286fb0b1@cs.ucla.edu>
[not found] ` <58281f96-f9c6-4567-e3c9-c6a6cfa6ce27@draigBrady.com>
[not found] ` <ZeZqzB4-OzHYfFeQ@codewreck.org>
[not found] ` <5914e8b2-48ac-456b-9753-6a7bae7a9bbb@cs.ucla.edu>
2024-03-05 14:16 ` bug#69532: mv's new -x option should be made orthogonal to -t/-T/default Pádraig Brady
2024-03-05 20:41 ` Karel Zak
2024-03-05 22:13 ` Masatake YAMATO
2024-03-17 6:10 ` Paul Eggert
2024-03-17 11:32 ` Pádraig Brady
2024-03-17 11:40 ` Pádraig Brady
2024-03-20 22:10 ` Paul Eggert
2024-03-20 19:43 ` Bernhard Voelker
2024-03-20 20:56 ` Paul Eggert
2024-03-20 22:53 ` Bernhard Voelker
2024-03-20 23:56 ` Paul Eggert
2024-03-21 21:45 ` Bernhard Voelker [this message]
2024-03-23 1:44 ` Paul Eggert
2024-03-23 10:24 ` Bernhard Voelker
2024-03-22 10:22 ` Karel Zak
2024-03-23 10:24 ` Bernhard Voelker
2024-03-21 0:03 ` Rob Landley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d6530404-4fc7-40d0-be99-cb37426be32d@bernhard-voelker.de \
--to=mail@bernhard-voelker.de \
--cc=69532@debbugs.gnu.org \
--cc=P@draigBrady.com \
--cc=asmadeus@codewreck.org \
--cc=eggert@cs.ucla.edu \
--cc=kzak@redhat.com \
--cc=oss@malat.biz \
--cc=rob@landley.net \
--cc=util-linux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.