Re: [PATCH] leds: mt6370: Remove an unused field in struct mt6370_priv

From: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
To: AngeloGioacchino Del Regno
	<angelogioacchino.delregno@collabora.com>,
	Pavel Machek <pavel@ucw.cz>, Lee Jones <lee@kernel.org>,
	Matthias Brugger <matthias.bgg@gmail.com>
Cc: linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org,
	linux-leds@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	linux-mediatek@lists.infradead.org
Subject: Re: [PATCH] leds: mt6370: Remove an unused field in struct mt6370_priv
Date: Mon, 29 Apr 2024 20:31:30 +0200	[thread overview]
Message-ID: <d526b169-0385-4f23-8806-17bc73c2507b@wanadoo.fr> (raw)
In-Reply-To: <16df315e-8a05-49a4-ac07-d1ed150c9317@collabora.com>

Le 29/04/2024 à 10:13, AngeloGioacchino Del Regno a écrit :
> Il 28/04/24 20:27, Christophe JAILLET ha scritto:
>> In "struct mt6370_priv", the 'reg_cfgs' field is unused.
>>
>> Moreover the "struct reg_cfg" is defined nowhere. Neither in this 
>> file, nor
>> in a global .h file, so it is completely pointless.
>>
>> Remove it.
> 
> Sure
> 
>>
>> Found with cppcheck, unusedStructMember.
>>
>> So, remove it.
> 
> Again?! :-P

Yes. This way we safe twice the memory space :).

> 
>>
>> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> 
> 
> Anyway, this commit misses a Fixes tag; please add the relevant one, 
> after which,

Will do, but this patch does not fix anything.
It is just a clean-up.

CJ

> 
> Reviewed-by: AngeloGioacchino Del Regno 
> <angelogioacchino.delregno@collabora.com>