From: Dave Hansen <dave.hansen@intel.com>
To: Samuel Holland <samuel.holland@sifive.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
Christoph Hellwig <hch@lst.de>,
loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4 10/15] x86: Implement ARCH_HAS_KERNEL_FPU_SUPPORT
Date: Fri, 29 Mar 2024 10:28:44 -0700 [thread overview]
Message-ID: <d2c3cd78-cdc6-4a39-9804-4f30402751b1@intel.com> (raw)
In-Reply-To: <20240329072441.591471-11-samuel.holland@sifive.com>
On 3/29/24 00:18, Samuel Holland wrote:
> +#
> +# CFLAGS for compiling floating point code inside the kernel.
> +#
> +CC_FLAGS_FPU := -msse -msse2
> +ifdef CONFIG_CC_IS_GCC
> +# Stack alignment mismatch, proceed with caution.
> +# GCC < 7.1 cannot compile code using `double` and -mpreferred-stack-boundary=3
> +# (8B stack alignment).
> +# See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53383
> +#
> +# The "-msse" in the first argument is there so that the
> +# -mpreferred-stack-boundary=3 build error:
> +#
> +# -mpreferred-stack-boundary=3 is not between 4 and 12
> +#
> +# can be triggered. Otherwise gcc doesn't complain.
> +CC_FLAGS_FPU += -mhard-float
> +CC_FLAGS_FPU += $(call cc-option,-msse -mpreferred-stack-boundary=3,-mpreferred-stack-boundary=4)
> +endif
I was expecting to see this (now duplicate) hunk come _out_ of
lib/Makefile somewhere in the series.
Did I miss that, or is there something keeping the duplicate there?
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Samuel Holland <samuel.holland@sifive.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
Christoph Hellwig <hch@lst.de>,
loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4 10/15] x86: Implement ARCH_HAS_KERNEL_FPU_SUPPORT
Date: Fri, 29 Mar 2024 10:28:44 -0700 [thread overview]
Message-ID: <d2c3cd78-cdc6-4a39-9804-4f30402751b1@intel.com> (raw)
In-Reply-To: <20240329072441.591471-11-samuel.holland@sifive.com>
On 3/29/24 00:18, Samuel Holland wrote:
> +#
> +# CFLAGS for compiling floating point code inside the kernel.
> +#
> +CC_FLAGS_FPU := -msse -msse2
> +ifdef CONFIG_CC_IS_GCC
> +# Stack alignment mismatch, proceed with caution.
> +# GCC < 7.1 cannot compile code using `double` and -mpreferred-stack-boundary=3
> +# (8B stack alignment).
> +# See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53383
> +#
> +# The "-msse" in the first argument is there so that the
> +# -mpreferred-stack-boundary=3 build error:
> +#
> +# -mpreferred-stack-boundary=3 is not between 4 and 12
> +#
> +# can be triggered. Otherwise gcc doesn't complain.
> +CC_FLAGS_FPU += -mhard-float
> +CC_FLAGS_FPU += $(call cc-option,-msse -mpreferred-stack-boundary=3,-mpreferred-stack-boundary=4)
> +endif
I was expecting to see this (now duplicate) hunk come _out_ of
lib/Makefile somewhere in the series.
Did I miss that, or is there something keeping the duplicate there?
_______________________________________________
linux-riscv mailing list
linux-riscv@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-riscv
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Samuel Holland <samuel.holland@sifive.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org, x86@kernel.org
Cc: linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org,
linuxppc-dev@lists.ozlabs.org, linux-riscv@lists.infradead.org,
Christoph Hellwig <hch@lst.de>,
loongarch@lists.linux.dev, amd-gfx@lists.freedesktop.org,
Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH v4 10/15] x86: Implement ARCH_HAS_KERNEL_FPU_SUPPORT
Date: Fri, 29 Mar 2024 10:28:44 -0700 [thread overview]
Message-ID: <d2c3cd78-cdc6-4a39-9804-4f30402751b1@intel.com> (raw)
In-Reply-To: <20240329072441.591471-11-samuel.holland@sifive.com>
On 3/29/24 00:18, Samuel Holland wrote:
> +#
> +# CFLAGS for compiling floating point code inside the kernel.
> +#
> +CC_FLAGS_FPU := -msse -msse2
> +ifdef CONFIG_CC_IS_GCC
> +# Stack alignment mismatch, proceed with caution.
> +# GCC < 7.1 cannot compile code using `double` and -mpreferred-stack-boundary=3
> +# (8B stack alignment).
> +# See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53383
> +#
> +# The "-msse" in the first argument is there so that the
> +# -mpreferred-stack-boundary=3 build error:
> +#
> +# -mpreferred-stack-boundary=3 is not between 4 and 12
> +#
> +# can be triggered. Otherwise gcc doesn't complain.
> +CC_FLAGS_FPU += -mhard-float
> +CC_FLAGS_FPU += $(call cc-option,-msse -mpreferred-stack-boundary=3,-mpreferred-stack-boundary=4)
> +endif
I was expecting to see this (now duplicate) hunk come _out_ of
lib/Makefile somewhere in the series.
Did I miss that, or is there something keeping the duplicate there?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
WARNING: multiple messages have this Message-ID (diff)
From: Dave Hansen <dave.hansen@intel.com>
To: Samuel Holland <samuel.holland@sifive.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-arm-kernel@lists.infradead.org, x86@kernel.org
Cc: linux-arch@vger.kernel.org, Thomas Gleixner <tglx@linutronix.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
loongarch@lists.linux.dev, linux-riscv@lists.infradead.org,
linuxppc-dev@lists.ozlabs.org, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH v4 10/15] x86: Implement ARCH_HAS_KERNEL_FPU_SUPPORT
Date: Fri, 29 Mar 2024 10:28:44 -0700 [thread overview]
Message-ID: <d2c3cd78-cdc6-4a39-9804-4f30402751b1@intel.com> (raw)
In-Reply-To: <20240329072441.591471-11-samuel.holland@sifive.com>
On 3/29/24 00:18, Samuel Holland wrote:
> +#
> +# CFLAGS for compiling floating point code inside the kernel.
> +#
> +CC_FLAGS_FPU := -msse -msse2
> +ifdef CONFIG_CC_IS_GCC
> +# Stack alignment mismatch, proceed with caution.
> +# GCC < 7.1 cannot compile code using `double` and -mpreferred-stack-boundary=3
> +# (8B stack alignment).
> +# See https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53383
> +#
> +# The "-msse" in the first argument is there so that the
> +# -mpreferred-stack-boundary=3 build error:
> +#
> +# -mpreferred-stack-boundary=3 is not between 4 and 12
> +#
> +# can be triggered. Otherwise gcc doesn't complain.
> +CC_FLAGS_FPU += -mhard-float
> +CC_FLAGS_FPU += $(call cc-option,-msse -mpreferred-stack-boundary=3,-mpreferred-stack-boundary=4)
> +endif
I was expecting to see this (now duplicate) hunk come _out_ of
lib/Makefile somewhere in the series.
Did I miss that, or is there something keeping the duplicate there?
next prev parent reply other threads:[~2024-03-29 17:28 UTC|newest]
Thread overview: 120+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-29 7:18 [PATCH v4 00/15] Unified cross-architecture kernel-mode FPU API Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` [PATCH v4 01/15] arch: Add ARCH_HAS_KERNEL_FPU_SUPPORT Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` [PATCH v4 02/15] ARM: Implement ARCH_HAS_KERNEL_FPU_SUPPORT Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` [PATCH v4 03/15] ARM: crypto: Use CC_FLAGS_FPU for NEON CFLAGS Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` [PATCH v4 04/15] arm64: Implement ARCH_HAS_KERNEL_FPU_SUPPORT Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` [PATCH v4 05/15] arm64: crypto: Use CC_FLAGS_FPU for NEON CFLAGS Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` [PATCH v4 06/15] lib/raid6: " Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` [PATCH v4 07/15] LoongArch: Implement ARCH_HAS_KERNEL_FPU_SUPPORT Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` [PATCH v4 08/15] powerpc: " Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` [PATCH v4 09/15] x86/fpu: Fix asm/fpu/types.h include guard Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 17:30 ` Dave Hansen
2024-03-29 17:30 ` Dave Hansen
2024-03-29 17:30 ` Dave Hansen
2024-03-29 17:30 ` Dave Hansen
2024-03-29 7:18 ` [PATCH v4 10/15] x86: Implement ARCH_HAS_KERNEL_FPU_SUPPORT Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 17:28 ` Dave Hansen [this message]
2024-03-29 17:28 ` Dave Hansen
2024-03-29 17:28 ` Dave Hansen
2024-03-29 17:28 ` Dave Hansen
2024-03-29 18:02 ` Samuel Holland
2024-03-29 18:02 ` Samuel Holland
2024-03-29 18:02 ` Samuel Holland
2024-03-29 18:02 ` Samuel Holland
2024-03-29 7:18 ` [PATCH v4 11/15] riscv: Add support for kernel-mode FPU Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` [PATCH v4 12/15] drm/amd/display: Only use hard-float, not altivec on powerpc Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-04-30 17:28 ` Harry Wentland
2024-04-30 17:28 ` Harry Wentland
2024-04-30 17:28 ` Harry Wentland
2024-04-30 17:28 ` Harry Wentland
2024-03-29 7:18 ` [PATCH v4 13/15] drm/amd/display: Use ARCH_HAS_KERNEL_FPU_SUPPORT Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-04-10 22:21 ` Thiago Jung Bauermann
2024-04-10 22:21 ` Thiago Jung Bauermann
2024-04-10 22:21 ` Thiago Jung Bauermann
2024-04-10 22:21 ` Thiago Jung Bauermann
2024-04-10 22:47 ` Samuel Holland
2024-04-10 22:47 ` Samuel Holland
2024-04-10 22:47 ` Samuel Holland
2024-04-10 22:47 ` Samuel Holland
2024-04-11 1:02 ` Thiago Jung Bauermann
2024-04-11 1:02 ` Thiago Jung Bauermann
2024-04-11 1:02 ` Thiago Jung Bauermann
2024-04-11 1:02 ` Thiago Jung Bauermann
2024-04-11 1:11 ` Samuel Holland
2024-04-11 1:11 ` Samuel Holland
2024-04-11 1:11 ` Samuel Holland
2024-04-11 1:11 ` Samuel Holland
2024-04-11 1:27 ` Thiago Jung Bauermann
2024-04-11 1:27 ` Thiago Jung Bauermann
2024-04-11 1:27 ` Thiago Jung Bauermann
2024-04-11 1:27 ` Thiago Jung Bauermann
2024-04-11 7:15 ` Ard Biesheuvel
2024-04-11 7:15 ` Ard Biesheuvel
2024-04-11 7:15 ` Ard Biesheuvel
2024-04-11 7:15 ` Ard Biesheuvel
2024-04-11 7:31 ` Arnd Bergmann
2024-04-11 7:31 ` Arnd Bergmann
2024-04-11 7:31 ` Arnd Bergmann
2024-04-11 7:31 ` Arnd Bergmann
2024-04-12 1:54 ` Dave Airlie
2024-04-12 1:54 ` Dave Airlie
2024-04-12 1:54 ` Dave Airlie
2024-04-12 1:54 ` Dave Airlie
2024-04-30 17:29 ` Harry Wentland
2024-04-30 17:29 ` Harry Wentland
2024-04-30 17:29 ` Harry Wentland
2024-04-30 17:29 ` Harry Wentland
2024-03-29 7:18 ` [PATCH v4 14/15] selftests/fpu: Move FP code to a separate translation unit Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` [PATCH v4 15/15] selftests/fpu: Allow building on other architectures Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-03-29 7:18 ` Samuel Holland
2024-04-03 12:51 ` [PATCH v4 00/15] Unified cross-architecture kernel-mode FPU API Christian König
2024-04-03 12:51 ` Christian König
2024-04-03 12:51 ` Christian König
2024-04-03 12:51 ` Christian König
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=d2c3cd78-cdc6-4a39-9804-4f30402751b1@intel.com \
--to=dave.hansen@intel.com \
--cc=akpm@linux-foundation.org \
--cc=amd-gfx@lists.freedesktop.org \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hch@lst.de \
--cc=linux-arch@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=loongarch@lists.linux.dev \
--cc=mingo@redhat.com \
--cc=samuel.holland@sifive.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.