Re: [bug report] WARNING: CPU: 0 PID: 1 at kernel/resource.c:834 __insert_resource+0x84/0x110

From: Baoquan He <bhe@redhat.com>
To: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Changhui Zhong <czhong@redhat.com>,
	linux-pci@vger.kernel.org, kexec@lists.infradead.org,
	Vivek Goyal <vgoyal@redhat.com>, Dave Young <dyoung@redhat.com>,
	chenhuacai@kernel.org, x86@kernel.org
Subject: Re: [bug report] WARNING: CPU: 0 PID: 1 at kernel/resource.c:834 __insert_resource+0x84/0x110
Date: Tue, 19 Mar 2024 22:42:39 +0800	[thread overview]
Message-ID: <ZfmkXw6pEBP73Txt@MiWiFi-R3L-srv> (raw)
In-Reply-To: <73a510c8-51a0-4a4a-1aa8-7bdcd4cdde22@linux.intel.com>

On 03/19/24 at 01:59pm, Ilpo Järvinen wrote:
> On Tue, 19 Mar 2024, Changhui Zhong wrote:
> 
> > Hello,
> > 
> > found a kernel warning issue at "kernel/resource.c:834
> > __insert_resource+0x84/0x110" ,please help check,
> > 
> > repo:https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git
> > branch: master
> > commit HEAD:f6cef5f8c37f58a3bc95b3754c3ae98e086631ca
> > 
> >  [    0.130164] ------------[ cut here ]------------
> > [    0.130370] WARNING: CPU: 0 PID: 1 at kernel/resource.c:834
> > __insert_resource+0x84/0x110
> > [    0.131364] Modules linked in:
> > [    0.132364] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 6.8.0+ #1
> > [    0.133365] Hardware name: Dell Inc. PowerEdge R640/06DKY5, BIOS
> > 2.15.1 06/15/2022
> > [    0.134364] RIP: 0010:__insert_resource+0x84/0x110
> > [    0.135364] Code: d0 4c 39 c1 76 b1 c3 cc cc cc cc 4c 8d 4a 30 48
> > 8b 52 30 48 85 d2 75 b7 48 89 56 30 49 89 31 48 89 46 28 31 c0 c3 cc
> > cc cc cc <0f> 0b 48 89 d0 c3 cc cc cc cc 49 89 d2 eb 1a 4d 39 42 08 77
> > 19 4d
> > [    0.136363] RSP: 0000:ffffb257400dfe08 EFLAGS: 00010246
> > [    0.137363] RAX: ffff9e147ffca640 RBX: 0000000000000000 RCX: 0000000026000000
> > [    0.138363] RDX: ffffffff86c45ee0 RSI: ffffffff86c45ee0 RDI: 0000000026000000
> > [    0.139363] RBP: ffffffff8684d120 R08: 0000000035ffffff R09: 0000000035ffffff
> > [    0.140363] R10: 000000002f31646f R11: 0000000059a7ffee R12: ffffffff86c45ee0
> > [    0.141363] R13: 0000000000000000 R14: 0000000000000000 R15: 0000000000000000
> > [    0.142363] FS:  0000000000000000(0000) GS:ffff9e1277800000(0000)
> > knlGS:0000000000000000
> > [    0.143363] CS:  0010 DS: 0000 ES: 0000 CR0: 0000000080050033
> > [    0.144363] CR2: ffff9e1333601000 CR3: 0000000332220001 CR4: 00000000007706f0
> > [    0.145363] DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
> > [    0.146363] DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
> > [    0.147363] PKRU: 55555554
> > [    0.148363] Call Trace:
> > [    0.149364]  <TASK>
> > [    0.150365]  ? __warn+0x7f/0x130
> > [    0.151363]  ? __insert_resource+0x84/0x110
> > [    0.152364]  ? report_bug+0x18a/0x1a0
> > [    0.153364]  ? handle_bug+0x3c/0x70
> > [    0.154363]  ? exc_invalid_op+0x14/0x70
> > [    0.155363]  ? asm_exc_invalid_op+0x16/0x20
> > [    0.156364]  ? __insert_resource+0x84/0x110
> > [    0.157364]  ? add_device_randomness+0x75/0xa0
> > [    0.158363]  insert_resource+0x26/0x50
> > [    0.159364]  ? __pfx_insert_crashkernel_resources+0x10/0x10
> > [    0.160363]  insert_crashkernel_resources+0x62/0x70
> 
> Hi,
> 
> This seems related to crashkernel stuff, I added a few Ccs related to 
> it.
> 
> I don't know why you sent this only to linux-pci list as it seems likely 
> to be entirely unrelated to PCI.

Too few info is provided. I guess this is happening on x86_64. Do you
have the kernel config, and what kernel you are testing? What operation
are you taking to trigger this?

Below commit could be suspect, but not sure if it's the real criminal.

commit 4a693ce65b186fddc1a73621bd6f941e6e3eca21
Author: Huacai Chen <chenhuacai@kernel.org>
Date:   Fri Dec 29 16:02:13 2023 +0800

    kdump: defer the insertion of crashkernel resources

Dave reported a similar one, he did kexec reboot firstly, then in 2nd
kernel crashkernel reservation will trigger the iomem inserting error.

[PATCH] x86/kexec: do not update E820 kexec table for setup_data
https://lore.kernel.org/all/ZeZ2Kos-OOZNSrmO@darkstar.users.ipa.redhat.com/T/#u

Can you try Dave's patch firstly? If it doesn't work, try reverting
above Huacai's patch? it may need manual editing.

> 
> -- 
>  i.
> 
> > [    0.161365]  do_one_initcall+0x41/0x300
> > [    0.162364]  kernel_init_freeable+0x21e/0x320
> > [    0.163365]  ? __pfx_kernel_init+0x10/0x10
> > [    0.164364]  kernel_init+0x16/0x1c0
> > [    0.165364]  ret_from_fork+0x2d/0x50
> > [    0.166364]  ? __pfx_kernel_init+0x10/0x10
> > [    0.167363]  ret_from_fork_asm+0x1a/0x30
> > [    0.168365]  </TASK>
> > [    0.169363] ---[ end trace 0000000000000000 ]---
> > 
> > Thanks,
> > 
> > 
> 