Re: [igt-dev] [PATCH i-g-t 09/17] Add subtest to copy raw source to protected dest

From: Rodrigo Vivi <rodrigo.vivi@intel.com>
To: Alan Previn <alan.previn.teres.alexis@intel.com>
Cc: igt-dev@lists.freedesktop.org
Subject: Re: [igt-dev] [PATCH i-g-t 09/17] Add subtest to copy raw source to protected dest
Date: Fri, 4 Jun 2021 09:22:25 -0400	[thread overview]
Message-ID: <YLopEQeWZ40kV59k@intel.com> (raw)
In-Reply-To: <20210518103344.2264397-10-alan.previn.teres.alexis@intel.com>

On Tue, May 18, 2021 at 03:33:36AM -0700, Alan Previn wrote:
> Add subtest to 3d-copy raw source buffer (with
> known readible content) to a destination buffer
> marked as protected with a protected session using
> default session keys. The destination buffer is
> verified to be different from the source (when
> read via CPU) because its encrypted.
> 
> Signed-off-by: Alan Previn <alan.previn.teres.alexis@intel.com>
> ---
>  tests/i915/gem_pxp.c | 55 ++++++++++++++++++++++++++++++++++++++++++++
>  1 file changed, 55 insertions(+)
> 
> diff --git a/tests/i915/gem_pxp.c b/tests/i915/gem_pxp.c
> index b1415efc..5a29024a 100644
> --- a/tests/i915/gem_pxp.c
> +++ b/tests/i915/gem_pxp.c
> @@ -376,7 +376,9 @@ static uint32_t alloc_and_fill_dest_buff(int i915, bool protected, uint32_t size
>  #define TSTSURF_STRIDE      (TSTSURF_WIDTH*TSTSURF_BYTESPP)
>  #define TSTSURF_SIZE        (TSTSURF_STRIDE*TSTSURF_HEIGHT)
>  #define TSTSURF_FILLCOLOR1  0xfaceface
> +#define TSTSURF_FILLCOLOR2  0xdeaddead
>  #define TSTSURF_INITCOLOR1  0x12341234
> +#define TSTSURF_INITCOLOR2  0x56785678

I couldn't understand why we can't simply reuse the ones who were there
already, but anyway:

Reviewed-by: Rodrigo Vivi <rodrigo.vivi@intel.com>

>  
>  static void test_render_baseline(int i915)
>  {
> @@ -422,6 +424,57 @@ static void test_render_baseline(int i915)
>  	buf_ops_destroy(bops);
>  }
>  
> +static void test_render_pxp_src_to_protdest(int i915)
> +{
> +	uint32_t ctx, srcbo, dstbo;
> +	struct intel_buf *srcbuf, *dstbuf;
> +	struct buf_ops *bops;
> +	struct intel_bb *ibb;
> +	uint32_t devid;
> +	int ret;
> +
> +	devid = intel_get_drm_devid(i915);
> +	igt_assert(devid);
> +
> +	bops = buf_ops_create(i915);
> +	igt_assert(bops);
> +
> +	/*
> +	 * Perform a protected render operation but only label
> +	 * the dest as protected. After rendering, the content
> +	 * should be encrypted
> +	 */
> +	ret = create_ctx_with_params(i915, true, true, true, false, &ctx);
> +	igt_assert_eq(ret, 0);
> +	igt_assert_eq(get_ctx_protected_param(i915, ctx), 1);
> +	ibb = intel_bb_create_with_context(i915, ctx, 4096);
> +	igt_assert(ibb);
> +	intel_bb_set_pxp(ibb, true, DISPLAY_APPTYPE, I915_PROTECTED_CONTENT_DEFAULT_SESSION);
> +
> +	dstbo = alloc_and_fill_dest_buff(i915, true, TSTSURF_SIZE, TSTSURF_INITCOLOR2);
> +	dstbuf = intel_buf_create_using_handle(bops, dstbo, TSTSURF_WIDTH, TSTSURF_HEIGHT,
> +						TSTSURF_BYTESPP*8, 0, I915_TILING_NONE, 0);
> +	intel_buf_set_pxp(dstbuf, true);
> +
> +	srcbo = alloc_and_fill_dest_buff(i915, false, TSTSURF_SIZE, TSTSURF_FILLCOLOR2);
> +	srcbuf = intel_buf_create_using_handle(bops, srcbo, TSTSURF_WIDTH, TSTSURF_HEIGHT,
> +						TSTSURF_BYTESPP*8, 0, I915_TILING_NONE, 0);
> +
> +	gen12_render_copyfunc(ibb, srcbuf, 0, 0, TSTSURF_WIDTH, TSTSURF_HEIGHT, dstbuf, 0, 0);
> +	gem_sync(i915, dstbo);
> +
> +	assert_bo_content_check(i915, dstbo, COMPARE_COLOR_UNREADIBLE,
> +				TSTSURF_SIZE, TSTSURF_FILLCOLOR2);
> +
> +	intel_bb_destroy(ibb);
> +	intel_buf_destroy(srcbuf);
> +	gem_close(i915, srcbo);
> +	intel_buf_destroy(dstbuf);
> +	gem_close(i915, dstbo);
> +	gem_context_destroy(i915, ctx);
> +	buf_ops_destroy(bops);
> +}
> +
>  igt_main
>  {
>  	int i915 = -1;
> @@ -493,6 +546,8 @@ igt_main
>  		igt_describe("Verify protected render operations:");
>  		igt_subtest("regular-baseline-src-copy-readible")
>  			test_render_baseline(i915);
> +		igt_subtest("protected-raw-src-copy-not-readible")
> +			test_render_pxp_src_to_protdest(i915);
>  	}
>  
>  	igt_fixture {
> -- 
> 2.25.1
> 
> _______________________________________________
> igt-dev mailing list
> igt-dev@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/igt-dev
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev